Mesa (main): iris: Delete a comment suggesting we use tiled staging buffers
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Jun 2 21:37:21 UTC 2021
Module: Mesa
Branch: main
Commit: 1c73445d22e148b6c35ff6a1fcc45fb99009cad4
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c73445d22e148b6c35ff6a1fcc45fb99009cad4
Author: Kenneth Graunke <kenneth at whitecape.org>
Date: Thu May 20 11:25:35 2021 -0700
iris: Delete a comment suggesting we use tiled staging buffers
We basically tried this, and it performed worse, so delete the
suggestion in the comments that we may want to do it someday.
Acked-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10941>
---
src/gallium/drivers/iris/iris_resource.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/src/gallium/drivers/iris/iris_resource.c b/src/gallium/drivers/iris/iris_resource.c
index 9fbf636970c..eb92f12e927 100644
--- a/src/gallium/drivers/iris/iris_resource.c
+++ b/src/gallium/drivers/iris/iris_resource.c
@@ -2058,8 +2058,7 @@ iris_transfer_map(struct pipe_context *ctx,
*
* Images are less clear-cut. Resolves can be destructive, removing some
* of the underlying compression, so we'd rather blit the data to a linear
- * temporary and map that, to avoid the resolve. (It might be better to
- * a tiled temporary and use the tiled_memcpy paths...)
+ * temporary and map that, to avoid the resolve.
*/
if (!(usage & PIPE_MAP_DISCARD_RANGE) &&
!iris_has_invalid_primary(res, level, 1, box->z, box->depth)) {
More information about the mesa-commit
mailing list