Mesa (main): u_format: Assert that array formats don't include BE swizzles.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jun 3 00:44:43 UTC 2021


Module: Mesa
Branch: main
Commit: c144f988e179e722feaa2fed030db166045ef496
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c144f988e179e722feaa2fed030db166045ef496

Author: Eric Anholt <eric at anholt.net>
Date:   Tue Apr 27 15:47:31 2021 -0700

u_format: Assert that array formats don't include BE swizzles.

Z32_FLOAT_S8X24_UINT and X32_S8X24_UINT are in fact the only non-bitmask
formats that have BE swizzles specified, but sorting out those two is
harder.

Acked-by: Adam Jackson <ajax at redhat.com>
Acked-by: Ilia Mirkin <imirkin at alum.mit.edu>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10505>

---

 src/util/format/u_format_parse.py | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/util/format/u_format_parse.py b/src/util/format/u_format_parse.py
index 2a5edab0461..aba4e29ee36 100644
--- a/src/util/format/u_format_parse.py
+++ b/src/util/format/u_format_parse.py
@@ -129,6 +129,10 @@ class Format:
             le_shift += channel.size
 
         if be_channels:
+            if self.is_array():
+                print(
+                    "{} is an array format and should not include BE swizzles in the CSV".format(self.name))
+                exit(1)
             self.be_channels = be_channels
             self.be_swizzles = be_swizzles
         else:



More information about the mesa-commit mailing list