Mesa (main): v3dv: Fix assert.

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: c51bdac7420149b9e20d673fed369c4a67f4e654
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c51bdac7420149b9e20d673fed369c4a67f4e654

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Sat Jun  5 00:02:45 2021 -0700

v3dv: Fix assert.

Fix defect reported by Coverity Scan.

Side effect in assertion (ASSERT_SIDE_EFFECT)
assignment_where_comparison_intended: Assignment deviceMask = 1U
has a side effect. This code will work differently in a non-debug
build.

Fixes: 234e1b7356e ("v3dv: implement VK_KHR_device_group")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11197>

---

 src/broadcom/vulkan/v3dv_cmd_buffer.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/broadcom/vulkan/v3dv_cmd_buffer.c b/src/broadcom/vulkan/v3dv_cmd_buffer.c
index 645b5d9d49e..d76363db2bd 100644
--- a/src/broadcom/vulkan/v3dv_cmd_buffer.c
+++ b/src/broadcom/vulkan/v3dv_cmd_buffer.c
@@ -5494,5 +5494,5 @@ VKAPI_ATTR void VKAPI_CALL
 v3dv_CmdSetDeviceMask(VkCommandBuffer commandBuffer, uint32_t deviceMask)
 {
    /* Nothing to do here since we only support a single device */
-   assert(deviceMask = 0x1);
+   assert(deviceMask == 0x1);
 }