Mesa (main): ci/lava: Handle proxy download failures
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Jun 10 06:26:34 UTC 2021
Module: Mesa
Branch: main
Commit: b902c901f4791af875df803dece978664f63ee5f
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b902c901f4791af875df803dece978664f63ee5f
Author: Daniel Stone <daniels at collabora.com>
Date: Wed Jun 9 15:00:50 2021 +0100
ci/lava: Handle proxy download failures
LAVA doesn't consider failure to download a kernel/initramfs as an
infrastructure error, rather just a user error for supplying a broken
URL. We know our URLs aren't broken (because we're perfect), so assume
that failures in download validation are network issues and retry when
we hit them.
LAVA itself has been fixed to retry internally, so we'll get that when
upgrade in a couple of weeks, but gloss over it for now.
Signed-off-by: Daniel Stone <daniels at collabora.com>
Reviewed-by: Gustavo Padovan <gustavo.padovan at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11218>
---
.gitlab-ci/lava_job_submitter.py | 3 +++
1 file changed, 3 insertions(+)
diff --git a/.gitlab-ci/lava_job_submitter.py b/.gitlab-ci/lava_job_submitter.py
index 3294915762d..ecaa5d142a4 100755
--- a/.gitlab-ci/lava_job_submitter.py
+++ b/.gitlab-ci/lava_job_submitter.py
@@ -116,6 +116,9 @@ def get_job_results(proxy, job_id, test_suite, test_case):
if 'error_type' in metadata and metadata['error_type'] == "Infrastructure":
print_log("LAVA job {} failed with Infrastructure Error. Retry.".format(job_id))
return False
+ if 'case' in metadata and metadata['case'] == "validate":
+ print_log("LAVA job {} failed validation (possible download error). Retry.".format(job_id))
+ return False
results_yaml = _call_proxy(proxy.results.get_testcase_results_yaml, job_id, test_suite, test_case)
results = yaml.load(results_yaml, Loader=loader(False))
More information about the mesa-commit
mailing list