Mesa (main): radv/winsys: add a small comment explaining the CHAIN bit

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: cfe7e81214b8a7b08681795acde1b192f90d71af
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cfe7e81214b8a7b08681795acde1b192f90d71af

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Tue Jun  8 14:46:58 2021 +0200

radv/winsys: add a small comment explaining the CHAIN bit

Without it the hardware launches an IB2 which might hang in some
rare situations.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11214>

---

 src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
index bb4e30678e7..3e83d1c8e97 100644
--- a/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
+++ b/src/amd/vulkan/winsys/amdgpu/radv_amdgpu_cs.c
@@ -571,6 +571,7 @@ radv_amdgpu_cs_execute_secondary(struct radeon_cmdbuf *_parent, struct radeon_cm
       if (parent->base.cdw + 4 > parent->base.max_dw)
          radv_amdgpu_cs_grow(&parent->base, 4);
 
+      /* Not setting the CHAIN bit will launch an IB2. */
       radeon_emit(&parent->base, PKT3(PKT3_INDIRECT_BUFFER_CIK, 2, 0));
       radeon_emit(&parent->base, child->ib.ib_mc_address);
       radeon_emit(&parent->base, child->ib.ib_mc_address >> 32);