Mesa (main): svga: Initialize pipe_shader_state for transform shaders

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jun 10 17:40:49 UTC 2021


Module: Mesa
Branch: main
Commit: 8a3fa2c4d587e803118518d03b4944917c72245b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8a3fa2c4d587e803118518d03b4944917c72245b

Author: Neha Bhende <bhenden at vmware.com>
Date:   Wed Jun  9 11:08:28 2021 -0700

svga: Initialize pipe_shader_state for transform shaders

This fixes crashes for opengl apps. Issue is found in vmware
internal testing

Fixes: f01c0565bb9 ("draw: free the NIR IR.")

Reviewed-by: Charmaine Lee <charmainel at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11274>

---

 src/gallium/drivers/svga/svga_state_tgsi_transform.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/svga/svga_state_tgsi_transform.c b/src/gallium/drivers/svga/svga_state_tgsi_transform.c
index e0b054acbcf..b049d557234 100644
--- a/src/gallium/drivers/svga/svga_state_tgsi_transform.c
+++ b/src/gallium/drivers/svga/svga_state_tgsi_transform.c
@@ -148,7 +148,7 @@ write_vpos(struct svga_context *svga,
    }
 
    if (!use_existing) {
-      struct pipe_shader_state state;
+      struct pipe_shader_state state = {0};
       struct tgsi_token *new_tokens = NULL;
 
       new_tokens = tgsi_write_vpos(shader->tokens,
@@ -197,7 +197,7 @@ transform_dynamic_indexing(struct svga_context *svga,
    struct tgsi_token *new_tokens = NULL;
 
    if (!use_existing) {
-      struct pipe_shader_state state;
+      struct pipe_shader_state state = {0};
       new_tokens = tgsi_remove_dynamic_indexing(shader->tokens,
                                                 info->const_buffers_declared,
                                                 info->samplers_declared,



More information about the mesa-commit mailing list