Mesa (main): pan/bi: Schedule FCMP.v2f16 with abs modifier

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Jun 15 20:41:30 UTC 2021


Module: Mesa
Branch: main
Commit: 097c9092af3d5515657c7f03eccec6d92e496464
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=097c9092af3d5515657c7f03eccec6d92e496464

Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Fri Jun 11 12:43:21 2021 -0400

pan/bi: Schedule FCMP.v2f16 with abs modifier

So many encoding restrictions, because Bifrost.

Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11327>

---

 src/panfrost/bifrost/bi_schedule.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/panfrost/bifrost/bi_schedule.c b/src/panfrost/bifrost/bi_schedule.c
index 9fa069e900d..04b94e73d75 100644
--- a/src/panfrost/bifrost/bi_schedule.c
+++ b/src/panfrost/bifrost/bi_schedule.c
@@ -362,6 +362,10 @@ bi_can_add(bi_instr *ins)
         if (ins->op == BI_OPCODE_FADD_V2F16 && ins->clamp)
                 return false;
 
+        /* +FCMP.v2f16 lacks abs modifier, use *FCMP.v2f16 instead */
+        if (ins->op == BI_OPCODE_FCMP_V2F16 && (ins->src[0].abs || ins->src[1].abs))
+                return false;
+
         /* TODO: some additional fp16 constraints */
         return bi_opcode_props[ins->op].add;
 }



More information about the mesa-commit mailing list