Mesa (main): iris: take a reference to memobj bo in iris_resource_from_memobj

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jun 23 11:10:53 UTC 2021


Module: Mesa
Branch: main
Commit: 2d87ea3166596a07259c96d33f3e4880417117cd
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2d87ea3166596a07259c96d33f3e4880417117cd

Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Thu Jun  3 15:13:54 2021 +0300

iris: take a reference to memobj bo in iris_resource_from_memobj

v2: and remove it from iris_memobj_create_from_handle ... (Nanley)

Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4969
Fixes: 772dc50d162 ("iris: hook up resource creation from memory object")
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Nanley Chery <nanley.g.chery at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11552>

---

 src/gallium/drivers/iris/iris_resource.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/gallium/drivers/iris/iris_resource.c b/src/gallium/drivers/iris/iris_resource.c
index d60a95529f9..35a0ecef538 100644
--- a/src/gallium/drivers/iris/iris_resource.c
+++ b/src/gallium/drivers/iris/iris_resource.c
@@ -334,8 +334,6 @@ iris_memobj_create_from_handle(struct pipe_screen *pscreen,
    memobj->format = whandle->format;
    memobj->stride = whandle->stride;
 
-   iris_bo_reference(memobj->bo);
-
    return &memobj->b;
 }
 
@@ -1253,6 +1251,8 @@ iris_resource_from_memobj(struct pipe_screen *pscreen,
    res->offset = offset;
    res->external_format = memobj->format;
 
+   iris_bo_reference(memobj->bo);
+
    return &res->base.b;
 }
 



More information about the mesa-commit mailing list