Mesa (main): radeonsi: remove incorrect comment about hangs in gfx10_ngg_gs_emit_epilogue

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Jun 24 03:17:06 UTC 2021


Module: Mesa
Branch: main
Commit: f7afcc3d11d170a4820a1e5defc9f3e26b2c7f7d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f7afcc3d11d170a4820a1e5defc9f3e26b2c7f7d

Author: Marek Olšák <marek.olsak at amd.com>
Date:   Thu Jun 17 11:26:25 2021 -0400

radeonsi: remove incorrect comment about hangs in gfx10_ngg_gs_emit_epilogue

Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11509>

---

 src/gallium/drivers/radeonsi/gfx10_shader_ngg.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/gfx10_shader_ngg.c b/src/gallium/drivers/radeonsi/gfx10_shader_ngg.c
index ca88581215b..edfe0ee3645 100644
--- a/src/gallium/drivers/radeonsi/gfx10_shader_ngg.c
+++ b/src/gallium/drivers/radeonsi/gfx10_shader_ngg.c
@@ -1878,9 +1878,7 @@ void gfx10_ngg_gs_emit_epilogue(struct si_shader_context *ctx)
 
    ac_build_wg_scan(&ctx->ac, &vertlive_scan);
 
-   /* Skip all exports (including index exports) when possible. At least on
-    * early gfx10 revisions this is also to avoid hangs.
-    */
+   /* Skip all exports (including index exports) when possible. */
    LLVMValueRef have_exports =
       LLVMBuildICmp(builder, LLVMIntNE, vertlive_scan.result_reduce, ctx->ac.i32_0, "");
    num_emit_threads = LLVMBuildSelect(builder, have_exports, num_emit_threads, ctx->ac.i32_0, "");



More information about the mesa-commit mailing list