Mesa (main): crocus: disable Z16 unorm textures on pre-gen8 as well.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Jun 30 01:04:52 UTC 2021


Module: Mesa
Branch: main
Commit: a56f364ea93ed8479e976aabb28a0fe32a4b8752
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a56f364ea93ed8479e976aabb28a0fe32a4b8752

Author: Dave Airlie <airlied at gmail.com>
Date:   Wed Jun 30 10:44:25 2021 +1000

crocus: disable Z16 unorm textures on pre-gen8 as well.

This fixes:
dEQP-GLES3.functional.fbo.completeness.renderable.texture.depth.depth_component_unsigned_short

as gallium will try an allocate a DS usage, but fallback to just
a sampling usage if that fails.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11646>

---

 src/gallium/drivers/crocus/crocus_formats.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/src/gallium/drivers/crocus/crocus_formats.c b/src/gallium/drivers/crocus/crocus_formats.c
index 61d1b49d222..e968978da37 100644
--- a/src/gallium/drivers/crocus/crocus_formats.c
+++ b/src/gallium/drivers/crocus/crocus_formats.c
@@ -517,6 +517,11 @@ crocus_is_format_supported(struct pipe_screen *pscreen,
 
    if (usage & PIPE_BIND_SAMPLER_VIEW) {
       supported &= isl_format_supports_sampling(devinfo, format);
+
+      /* disable Z16 unorm depth textures pre gen8 */
+      if (devinfo->ver < 8 && pformat == PIPE_FORMAT_Z16_UNORM)
+         supported = false;
+
       bool ignore_filtering = false;
 
       if (is_integer)



More information about the mesa-commit mailing list