Mesa (master): radv: remove useless decompression of the DS resolve attachment

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Mar 1 18:21:28 UTC 2021


Module: Mesa
Branch: master
Commit: 97925cee8dc4328080fbf1377f66321787916efe
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=97925cee8dc4328080fbf1377f66321787916efe

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Feb 24 18:59:38 2021 +0100

radv: remove useless decompression of the DS resolve attachment

The DS resolve attachment is the destination attachment, it doesn't
need to be decompressed before resolving the depth/stencil attachment.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9256>

---

 src/amd/vulkan/radv_meta_resolve.c | 16 ----------------
 1 file changed, 16 deletions(-)

diff --git a/src/amd/vulkan/radv_meta_resolve.c b/src/amd/vulkan/radv_meta_resolve.c
index 649ba4aead1..b248a1fb661 100644
--- a/src/amd/vulkan/radv_meta_resolve.c
+++ b/src/amd/vulkan/radv_meta_resolve.c
@@ -978,22 +978,6 @@ radv_decompress_resolve_subpass_src(struct radv_cmd_buffer *cmd_buffer)
 		radv_decompress_resolve_src(cmd_buffer, src_image,
 					    src_att.layout, &region);
 	}
-
-	if (subpass->ds_resolve_attachment) {
-		struct radv_subpass_attachment src_att = *subpass->depth_stencil_attachment;
-		struct radv_image_view *src_iview = fb->attachments[src_att.attachment];
-		struct radv_image *src_image = src_iview->image;
-
-		VkImageResolve2KHR region = {0};
-		region.sType = VK_STRUCTURE_TYPE_IMAGE_RESOLVE_2_KHR;
-		region.srcSubresource.aspectMask = src_iview->aspect_mask;
-		region.srcSubresource.mipLevel = 0;
-		region.srcSubresource.baseArrayLayer = src_iview->base_layer;
-		region.srcSubresource.layerCount = layer_count;
-
-		radv_decompress_resolve_src(cmd_buffer, src_image,
-					    src_att.layout, &region);
-	}
 }
 
 static struct radv_sample_locations_state *



More information about the mesa-commit mailing list