Mesa (staging/20.3): radv: don't set sx_blend_opt_epsilon for V_028C70_COLOR_10_11_11
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Thu Mar 11 22:01:33 UTC 2021
Module: Mesa
Branch: staging/20.3
Commit: 62dd1015ee3ba70fd9a5c49dae31a623957d1425
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=62dd1015ee3ba70fd9a5c49dae31a623957d1425
Author: Rhys Perry <pendingchaos02 at gmail.com>
Date: Fri Mar 5 10:58:03 2021 +0000
radv: don't set sx_blend_opt_epsilon for V_028C70_COLOR_10_11_11
Matches radeonsi and PAL. From PAL:
// 1 is recommended, but doesn't provide sufficient precision
Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/4394
Fixes: ed946381564 ("radv: Enable RB+ where possible.")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9427>
(cherry picked from commit 524848707b4f2635a64b42bff1e530f0d6e0c0cd)
---
.pick_status.json | 2 +-
src/amd/vulkan/radv_cmd_buffer.c | 4 +---
2 files changed, 2 insertions(+), 4 deletions(-)
diff --git a/.pick_status.json b/.pick_status.json
index 16074e0657b..f943ac5d963 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -2065,7 +2065,7 @@
"description": "radv: don't set sx_blend_opt_epsilon for V_028C70_COLOR_10_11_11",
"nominated": true,
"nomination_type": 1,
- "resolution": 0,
+ "resolution": 1,
"master_sha": null,
"because_sha": "ed9463815644c85c124c72111d96e256db2986b4"
},
diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index 8488190a8a0..736c43bd2cc 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -1190,10 +1190,8 @@ radv_emit_rbplus_state(struct radv_cmd_buffer *cmd_buffer)
break;
case V_028C70_COLOR_10_11_11:
- if (spi_format == V_028714_SPI_SHADER_FP16_ABGR) {
+ if (spi_format == V_028714_SPI_SHADER_FP16_ABGR)
sx_ps_downconvert |= V_028754_SX_RT_EXPORT_10_11_11 << (i * 4);
- sx_blend_opt_epsilon |= V_028758_11BIT_FORMAT << (i * 4);
- }
break;
case V_028C70_COLOR_2_10_10_10:
More information about the mesa-commit
mailing list