Mesa (main): panfrost: Don't select the blit shader fragout type twice

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri May 7 16:11:29 UTC 2021


Module: Mesa
Branch: main
Commit: 09e65df92e9f9457f9116bb04f581871ed0ce18f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=09e65df92e9f9457f9116bb04f581871ed0ce18f

Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Fri Apr 30 15:17:50 2021 +0200

panfrost: Don't select the blit shader fragout type twice

The type has already been selected when forging the key, no need to do
it again pan_blitter_emit_bifrost_blend().

Signed-off-by: Boris Brezillon <boris.brezillon at collabora.com>
Reviewed-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10548>

---

 src/panfrost/lib/pan_blitter.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/src/panfrost/lib/pan_blitter.c b/src/panfrost/lib/pan_blitter.c
index 2d853457a60..f6e22abf1c2 100644
--- a/src/panfrost/lib/pan_blitter.c
+++ b/src/panfrost/lib/pan_blitter.c
@@ -224,10 +224,7 @@ pan_blitter_emit_bifrost_blend(const struct panfrost_device *dev,
                         return;
                 }
 
-                nir_alu_type type =
-                        (util_format_is_pure_uint(iview->format)) ? nir_type_uint32 :
-                        (util_format_is_pure_sint(iview->format)) ? nir_type_int32 :
-                        nir_type_float32;
+                nir_alu_type type = blit_shader->key.surfaces[rt].type;
 
                 cfg.round_to_fb_precision = true;
                 cfg.srgb = util_format_is_srgb(iview->format);



More information about the mesa-commit mailing list