Mesa (main): zink: break zs clear loop once both bits are set when beginning renderpass

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon May 10 01:11:31 UTC 2021


Module: Mesa
Branch: main
Commit: 5ac6c70214dc664238cc1fefcd42d5b2f0b3b30d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=5ac6c70214dc664238cc1fefcd42d5b2f0b3b30d

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Thu Apr  8 13:42:46 2021 -0400

zink: break zs clear loop once both bits are set when beginning renderpass

no point in looping this any more than we have to

Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10705>

---

 src/gallium/drivers/zink/zink_context.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/gallium/drivers/zink/zink_context.c b/src/gallium/drivers/zink/zink_context.c
index 6da5d1b3dd0..899761814c0 100644
--- a/src/gallium/drivers/zink/zink_context.c
+++ b/src/gallium/drivers/zink/zink_context.c
@@ -1188,7 +1188,9 @@ zink_begin_render_pass(struct zink_context *ctx, struct zink_batch *batch)
          assert(ctx->framebuffer->rp->state.clears);
       }
       if (zink_fb_clear_needs_explicit(fb_clear)) {
-         for (int j = !zink_fb_clear_element_needs_explicit(clear); j < zink_fb_clear_count(fb_clear); j++)
+         for (int j = !zink_fb_clear_element_needs_explicit(clear);
+              (clear_buffers & PIPE_CLEAR_DEPTHSTENCIL) != PIPE_CLEAR_DEPTHSTENCIL && j < zink_fb_clear_count(fb_clear);
+              j++)
             clear_buffers |= zink_fb_clear_element(fb_clear, j)->zs.bits;
       }
    }



More information about the mesa-commit mailing list