Mesa (staging/21.1): 26 new commits

Wed May 12 19:41:06 UTC 2021

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6ba5eb1ecb6be568b3a306b45e355784ca0dc686
Author: Daniel Schürmann <daniel at schuermann.dev>
Date:   Tue May 11 22:58:27 2021 +0200

    aco: fix additional register requirements for spilling

    It could happen that VGPR spilling without SGPR spilling
    calculated a negative spills_to_vgpr number and then
    increasing the VGPR target demand above the limit.

    Cc: mesa-stable

    Reviewed-by: Tony Wasserka <tony.wasserka at gmx.de>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10756>
    (cherry picked from commit 989e9867a64045421cf77c0d0bb2d184408ed21f)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=382ffa60959d14cc5fcc5feae0998a791f4fcb99
Author: Marcin Ślusarz <marcin.slusarz at intel.com>
Date:   Thu Nov 12 20:13:26 2020 +0100

    nir: handle float atomics in nir_lower_memory_model

    Signed-off-by: Marcin Ślusarz <marcin.slusarz at intel.com>
    Reviewed-by: Rhys Perry <pendingchaos02 at gmail.com>
    Fixes: 2adb337256f ("nir,radv/aco: add and use pass to lower make available/visible barriers")
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10766>
    (cherry picked from commit 2c3e2d69bd1e1ab715783f0ef41daf99519ed12e)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=00ede5f163228b218745c6ff14282da651544b84
Author: Eric Engestrom <eric at engestrom.ch>
Date:   Wed May 12 21:39:06 2021 +0200

    .pick_status.json: Update to e8640fef9089bb31a9e602a8894ae4fe84086118

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d25ff22af39e666307538a459e50b6643af0a6a4
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Tue May 4 15:08:07 2021 -0400

    iris: refcount separate screen objects for resource tracking

    this screen object can never, ever be accessed like this in a resource,
    as it may have previously been replaced by a wrapper (e.g., driver trace)
    which will then explode when it is accessed directly

    instead, keep a separate screen ref on the resource which is known to be
    the actual driver object and not a wrapper

    Fixes: 0a497eb1303 ("iris: make resources take a ref on the screen object")

    Reviewed-by: Lionel Landwerlin lionel.g.landwerlin at intel.com
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10632>
    (cherry picked from commit eb63c7decedb6188122f01d9851c44aa8d1d0e33)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=83e3a129c6be90a53b1953f4b5f3f7666ae301ed
Author: Juan A. Suarez Romero <jasuarez at igalia.com>
Date:   Fri Apr 30 12:49:59 2021 +0200

    v3d: fix resource leak in error path

    Do not leak pipe resource if scanout resource creation fails.

    Fixes: bf6973199d1 ("v3d: Allow the UIF modifier with renderonly.")
    Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
    Signed-off-by: Juan A. Suarez Romero <jasuarez at igalia.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10643>
    (cherry picked from commit 66bf683ca9b5889aa05c32d3e35ea2649bab7d23)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=de9c715784e8f2dcc4188d9d060f94c1611e87e1
Author: Eric Engestrom <eric at engestrom.ch>
Date:   Sun May 9 18:10:32 2021 +0200

    egl/x11: don't forget to exit the attrib list loop

    Without this check, if we receive any attribs from the client, we either
    find an X11/XCB screen fd in there, or we keep going until we end up in
    random bits of memory and crash.

    Fixes: 4aebd86f9a1b0db0ebcc ("egl/x11: pick the user requested screen")
    Signed-off-by: Eric Engestrom <eric at engestrom.ch>
    Reviewed-by: Adam Jackson <ajax at redhat.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10717>
    (cherry picked from commit 2af08bf7b69a5f3b8f94b8669f1bff67405ca396)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=96307752bb3322f297e34f3e9e935dc371534ce3
Author: Karol Herbst <kherbst at redhat.com>
Date:   Wed Jan 27 22:09:16 2021 +0100

    clover/memory: fix data race in buffer subclasses

    Cc: mesa-stable
    Signed-off-by: Karol Herbst <kherbst at redhat.com>
    Reviewed-by: Zoltán Böszörményi <zboszor at gmail.com>
    Reviewed-by: Pierre Moreau <dev at pmoreau.org>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/8765>
    (cherry picked from commit 98280e834873a0f8711aa489a2a4e256a25566d0)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4ee7244c27aaa46a47d3c21d02c7de3d44fcd58f
Author: Mauro Rossi <issor.oruam at gmail.com>
Date:   Sat May 8 12:42:10 2021 +0200

    android: nir: add nir_lower_fragcolor.c to Makefile.sources

    Fixes the following building error:

    FAILED: out/target/product/x86_64/obj/SHARED_LIBRARIES/gallium_dri_intermediates/LINKED/gallium_dri.so
    ...
    ld.lld: error: undefined symbol: nir_lower_fragcolor
    >>> referenced by pan_assemble.c:81 (external/mesa/src/gallium/drivers/panfrost/pan_assemble.c:81)

    Cc: 21.0 21.1 <mesa-stable at lists.freedesktop.org>
    Fixes: 1fd356302590 ("nir: add lowering pass for fragcolor -> fragdata")
    Acked-by: Rob Clark <robclark at freedesktop.org>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10712>
    (cherry picked from commit 2736ae0454d574a1909863d7870fa4f1fe91bd7d)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=79b43881561cfc2341f3ab217f56d654d0c57112
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Fri May 7 18:07:12 2021 +0200

    radv: fix extending the dirty bits to 64-bit

    New dynamic states added for VK_EXT_extended_dynamic_state2 causes
    GPU hangs with vkd3d-proton.

    Fixes: 7bdd569d7e1 ("radv: extend the dirty bits to 64-bit")
    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10693>
    (cherry picked from commit 54b0cfb061ec393abdd9cf5bc7f43cb898c8fd4d)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=09890e9cb9f1dfed23381e7b36f4357a3cdafc88
Author: Dave Airlie <airlied at redhat.com>
Date:   Fri May 7 11:26:35 2021 +1000

    gallivm: handle texture arrays in non-fragment shaders with lod.

    We have to unwind the lod into the scalar path correctly.

    Fixes a crash with renderdoc demo

    Fixes: e168d148d76d ("gallivm/nir: handle non-uniform texture offsets")
    Reviewed-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10676>
    (cherry picked from commit 83a05caaf2ce4fa9d6605eddd5658bf400f642fb)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=4f99759370e926df9e9fbb97e55e9e20da56f911
Author: Boris Brezillon <boris.brezillon at collabora.com>
Date:   Tue May 4 08:31:38 2021 +0200

    Revert "gallium/util: Fix depth/stencil blit shaders"

    This reverts commit 7ca72f172678116d29d254b786a9422b864aef3d.
    Unlike what's stated in this commit, the depth or stencil components
    have to be replicated on all channels, as specified in the
    "Texture Sampling and Texture Formats" section of the TGSI doc
    (docs/gallium/tgsi.rst).

    Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10649>
    (cherry picked from commit 6cac9c748eb81105b5cd7df32060ee8aae2b1e5f)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7c3ec53a123a41a9b0789d735d68d35635713396
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Mon May 3 17:56:27 2021 +0200

    radv: fix missing ITERATE_256 for D/S MSAA images that are TC-compat HTILE

    To make them readable by shaders, only needed on GFX10+.

    This also fixes corruption with Control and MSAA.

    Cc: 21.1 mesa-stable
    Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
    Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10610>
    (cherry picked from commit 33ede796d5b9149076738b031137b4389dab71a1)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7ccaf8092093f396ff0c67f49820debbb5d013f2
Author: Eric Engestrom <eric at engestrom.ch>
Date:   Tue May 11 22:42:55 2021 +0200

    .pick_status.json: Update to 584145ea882b710027ce620a5d505bd25ab284b1

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=b125ee559a3d733c25848a3b525a15100e054ee8
Author: Jordan Justen <jordan.l.justen at intel.com>
Date:   Mon Apr 26 12:29:30 2021 -0700

    bin/pick: Rename master branch to main

    Signed-off-by: Jordan Justen <jordan.l.justen at intel.com>
    Reviewed-by: Dylan Baker <dylan at pnwbakers.com>
    Reviewed-by: Eric Engestrom <eric at engestrom.ch>
    (cherry picked from commit 6e86d1f503d8b017bd6679a4db70fef532595f65)

    [Eric: botched up Jordan's commit to not break anything on the release branch]

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=da315007b815076498ef2bdf28000d25b14dd91a
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date:   Tue May 4 13:04:48 2021 +0200

    gallium/u_vbuf: avoid dereferencing NULL pointer

    When I last time fixed this, I missed that continuing here would make us
    leak pointers in the translate state, which is what made this avoid a
    crash in the first place.

    That's not great, we need to set *some* pointer in this case. The
    obvious option would be NULL, but that means that the translate-code
    also needs to support NULL-pointers here.

    Instead, let's point to a small, static buffer that contains enough
    zero-data for the largest possible vertex attribute. This avoids having
    to add more NULL-checks.

    Fixes: a8e8204b186 ("gallium/u_vbuf: support NULL-resources")
    Reviewed-by: Marek Olšák <marek.olsak at amd.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/7773>
    (cherry picked from commit a2d091694f8cf30f7f8a15d9c26712d4e56eaa6c)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fb696bbbe268f5642c81328879c42963ad699be7
Author: Danylo Piliaiev <dpiliaiev at igalia.com>
Date:   Mon Feb 15 15:53:46 2021 +0200

    ir3: memory_barrier also controls shared memory access order

    nir_intrinsic_memory_barrier has the same semantic as memoryBarrier()
    in GLSL, which is:

    GLSL 4.60, 4.10. "Memory Qualifiers":
     "The built-in function memoryBarrier() can be used if needed to
     guarantee the completion and relative ordering of memory accesses
     performed by a single shader invocation."

    GLSL 4.60, 8.17. "Shader Memory Control Functions":
     "The built-in functions memoryBarrier() and groupMemoryBarrier() wait
     for the completion of accesses to all of the above variable types."

    Fixes tests:
     dEQP-VK.memory_model.message_passing.core11.u32.coherent.fence_fence.atomicwrite.device.payload_local.image.guard_nonlocal.workgroup.comp
     dEQP-VK.memory_model.message_passing.core11.u32.coherent.fence_fence.atomicwrite.device.payload_nonlocal.workgroup.guard_local.image.comp

    Fixes: 819a613a ("freedreno/ir3: moar better scheduler")

    Signed-off-by: Danylo Piliaiev <dpiliaiev at igalia.com>
    Reviewed-by: Samuel Iglesias Gonsálvez <siglesias at igalia.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/9054>
    (cherry picked from commit cb8a00791cc9618f5be903c31abf737b42e4cf46)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ceafcf3daf20763795bda6a9f166443bd84b7bf4
Author: Erik Faye-Lund <erik.faye-lund at collabora.com>
Date:   Thu Apr 22 13:46:41 2021 +0200

    docs: do not generate redirects on error

    The build-finished event is also triggered when there's an error. I
    somehow got the second argument wrong, and ended up ignoring the case.
    This can lead to new exceptions being thrown due to missing files, that
    ends up hiding the real problem.

    Fixes: 64a4ba9e1ce ("docs: add an extension to generate redirects")
    Reviewed-by: Eric Engestrom <eric at engestrom.ch>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10407>
    (cherry picked from commit 2736370294427d87933ce7ae293e0465fbab77e2)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=db3c2cdf824bba166c453743b2892274a4e8a0e3
Author: Marek Olšák <marek.olsak at amd.com>
Date:   Wed Apr 28 17:19:43 2021 -0400

    Revert "gallium/u_threaded: align batches and call slots to 16 bytes"

    This reverts commit 3b1ce49bc1e5aff87805b0bab255885c84bf5052.

    It will be completely rewritten, but let's revert this first.

    Reviewed-by: Pierre-Eric Pelloux-Prayer <pierre-eric.eric.pelloux-prayer at amd.com>
    Acked-By: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10606>
    (cherry picked from commit 954f59f2af4a135f2af2d2b6e341b4332ad3cccd)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bb746def48d6ba0aa875d97b62685e39bad80dae
Author: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Date:   Thu Apr 29 12:10:13 2021 -0700

    nir: Move shared_memory_explicit_layout bit into common shader_info

    Move it out of the "cs" sub-struct, since the bit can be used for
    other shader stages in the future.

    This also removes a subtle issue in spirv_to_nir:
    info.cs.shared_memory_explicit_layout was used without checking for
    the CS shader stage.  It ended up being "harmless" since the effects
    also depended on presence of shared variables.

    Fixes: 5de6c5973a6 ("spirv: Implement SPV_KHR_workgroup_memory_explicit_layout")
    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10529>
    (cherry picked from commit dd48683cfd6daf07602b7e92b96baf3704489fd7)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=2ceb11aaa837f609626cfab5497d5adb4e49c7b7
Author: Connor Abbott <cwabbott0 at gmail.com>
Date:   Fri Apr 30 18:05:37 2021 +0200

    freedreno/a6xx: Fix SP_GS_PRIM_SIZE for large sizes

    This fixes a few piglit hangs.

    Fixes: 0eebedb ("freedreno/a6xx: Emit program state for GS")
    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10551>
    (cherry picked from commit e7b7908f87a437b3d4a239bf9f2119154967757e)

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=1947597f748a7c243d41a5a416139f09ff7bb936
Author: Eric Engestrom <eric at engestrom.ch>
Date:   Mon May 10 19:43:26 2021 +0200

    .pick_status.json: Update to a1c56b80915a1105c5a62aa6ff3ac71c1edd143d

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=f08e0a2016bf40c055df360a1c3b745ec8b463d0
Author: Dylan Baker <dylan.c.baker at intel.com>
Date:   Wed Apr 28 16:14:58 2021 -0700

    meson/vulkan: fix linkage on windows

    The current approach likley breaks icl and clang-cl, but it seems that
    the problem isn't even really related to MSVC, but to Meson's Visual
    Studio backend, as such, let's use link-whole unless we're using a
    Visual Studio backend.

    Fixes: 48d31a6280c4de07279435606a5c0524c1787cad
           ("meson: link vulkan_util with link_whole on mingw")

    Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
    Acked-by: James Park <jpark37 at lagfreegames.com>
    (cherry picked from commit f03da01fe374b87b5144c77f56ab78cf7c2a2ed3)

    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10379>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=c51a8d12734e3ed05d0c02713f7452bccad8622e
Author: Michel Zou <xantares09 at hotmail.com>
Date:   Sun Apr 18 15:44:58 2021 +0200

    meson: link vulkan_util with link_whole on mingw

    It was missing for mingw.

    Closes #4633

    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    Acked-by: James Park <jpark37 at lagfreegames.com>
    (cherry picked from commit 48d31a6280c4de07279435606a5c0524c1787cad)

    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10379>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=62e4fe2300fc92514d13df9281045e8bdbe8377d
Author: Michel Zou <xantares09 at hotmail.com>
Date:   Thu Apr 15 22:38:24 2021 +0200

    vulkan: fix duplicate win32 def

    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    (cherry picked from commit dc036b17695318cd9c7f8e3376c017e896c2d1b1)

    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10379>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=7257be4d7020c35598ad139469ba2e805cfea59b
Author: Michel Zou <xantares09 at hotmail.com>
Date:   Thu Apr 15 22:37:58 2021 +0200

    lavapipe: fix unused variable warning

    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    (cherry picked from commit 45f32ce239bcc756c9720896d12bc02d9e6cdc50)

    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10379>

URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0fff844cf9de27fbee548f16e67a78180a9b9412
Author: Michel Zou <xantares09 at hotmail.com>
Date:   Thu Apr 15 22:38:44 2021 +0200

    gallium: fix uninitialized variable warning

    Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
    (cherry picked from commit 54deb1010f7db2a1d73557194557ab0ac851b30f)

    Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10379>