Mesa (main): panfrost: Make clear which limits are arbitrary

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: e249eaf141a0e96dc9bf66201a74c5113b91148f
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e249eaf141a0e96dc9bf66201a74c5113b91148f

Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date:   Mon May 10 13:21:27 2021 -0400

panfrost: Make clear which limits are arbitrary

Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/10845>

---

 src/gallium/drivers/panfrost/pan_screen.c | 8 +++-----
 1 file changed, 3 insertions(+), 5 deletions(-)

diff --git a/src/gallium/drivers/panfrost/pan_screen.c b/src/gallium/drivers/panfrost/pan_screen.c
index e2fe025730b..818e6fa7ed0 100644
--- a/src/gallium/drivers/panfrost/pan_screen.c
+++ b/src/gallium/drivers/panfrost/pan_screen.c
@@ -335,16 +335,15 @@ panfrost_get_shader_param(struct pipe_screen *screen,
             !(shader == PIPE_SHADER_COMPUTE && is_deqp))
                 return 0;
 
-        /* this is probably not totally correct.. but it's a start: */
         switch (param) {
         case PIPE_SHADER_CAP_MAX_INSTRUCTIONS:
         case PIPE_SHADER_CAP_MAX_ALU_INSTRUCTIONS:
         case PIPE_SHADER_CAP_MAX_TEX_INSTRUCTIONS:
         case PIPE_SHADER_CAP_MAX_TEX_INDIRECTIONS:
-                return 16384;
+                return 16384; /* arbitrary */
 
         case PIPE_SHADER_CAP_MAX_CONTROL_FLOW_DEPTH:
-                return 1024;
+                return 1024; /* arbitrary */
 
         case PIPE_SHADER_CAP_MAX_INPUTS:
                 /* Hardware limit is 4095 but we have driver internal inputs */
@@ -355,7 +354,7 @@ panfrost_get_shader_param(struct pipe_screen *screen,
                 return shader == PIPE_SHADER_FRAGMENT ? 8 : PIPE_MAX_ATTRIBS;
 
         case PIPE_SHADER_CAP_MAX_TEMPS:
-                return 256; /* GL_MAX_PROGRAM_TEMPORARIES_ARB */
+                return 256; /* arbitrary */
 
         case PIPE_SHADER_CAP_MAX_CONST_BUFFER_SIZE:
                 return 16 * 1024 * sizeof(float);
@@ -438,7 +437,6 @@ panfrost_get_shader_param(struct pipe_screen *screen,
                 return 0;
 
         default:
-                /* Other params are unknown */
                 return 0;
         }