Mesa (main): radv: stop reporting SQTT/RGP support as experimental

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Nov 1 20:03:51 UTC 2021


Module: Mesa
Branch: main
Commit: 3839f3a48630db843e414dfb979b03644bf5826b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=3839f3a48630db843e414dfb979b03644bf5826b

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Oct 20 08:53:07 2021 +0200

radv: stop reporting SQTT/RGP support as experimental

It can be considered stable these days. This also now reports the
buffer size and if instruction timing is enabled/disabled.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13477>

---

 src/amd/vulkan/radv_device.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)

diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 21983a577c9..0572d0e4c17 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -3100,10 +3100,6 @@ radv_CreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCr
    }
 
    if (radv_thread_trace_enabled()) {
-      fprintf(stderr, "*************************************************\n");
-      fprintf(stderr, "* WARNING: Thread trace support is experimental *\n");
-      fprintf(stderr, "*************************************************\n");
-
       if (device->physical_device->rad_info.chip_class < GFX8 ||
           device->physical_device->rad_info.chip_class > GFX10_3) {
          fprintf(stderr, "GPU hardware not supported: refer to "
@@ -3114,6 +3110,11 @@ radv_CreateDevice(VkPhysicalDevice physicalDevice, const VkDeviceCreateInfo *pCr
 
       if (!radv_thread_trace_init(device))
          goto fail;
+
+      fprintf(stderr, "radv: Thread trace support is enabled (initial buffer size: %u MiB, "
+                      "instruction timing: %s).\n",
+              device->thread_trace.buffer_size / (1024 * 1024),
+              radv_is_instruction_timing_enabled() ? "enabled" : "disabled");
    }
 
    if (getenv("RADV_TRAP_HANDLER")) {



More information about the mesa-commit mailing list