Mesa (main): r300: stub derivatives on r300 and r400 hardware

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: e1c640c3a43d741719864b35cbf855aa82be0611
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e1c640c3a43d741719864b35cbf855aa82be0611

Author: Filip Gawin <filip.gawin at zoho.com>
Date:   Wed Nov  3 11:42:18 2021 +0100

r300: stub derivatives on r300 and r400 hardware

There are three approaches for problem:
- use dummy shader (current solution)
- use software rendering
- stub

First option always gonna give bad results, second one
gonna be slideshow (r300/r400 at best are running with
old 2 cores cpu), third one can sometimes give graphical
gliches.

IMHO third one is least annoying option.

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13642>

---

 src/gallium/drivers/r300/compiler/r3xx_fragprog.c     |  1 +
 .../drivers/r300/compiler/radeon_program_alu.c        | 19 +++++++++++++++++++
 .../drivers/r300/compiler/radeon_program_alu.h        |  5 +++++
 3 files changed, 25 insertions(+)

diff --git a/src/gallium/drivers/r300/compiler/r3xx_fragprog.c b/src/gallium/drivers/r300/compiler/r3xx_fragprog.c
index d03462c52c8..b3ccb7a429b 100644
--- a/src/gallium/drivers/r300/compiler/r3xx_fragprog.c
+++ b/src/gallium/drivers/r300/compiler/r3xx_fragprog.c
@@ -109,6 +109,7 @@ void r3xx_compile_fragment_program(struct r300_fragment_program_compiler* c)
 
 	struct radeon_program_transformation native_rewrite_r300[] = {
 		{ &radeonTransformALU, 0 },
+		{ &radeonStubDeriv, 0 },
 		{ &r300_transform_trig_simple, 0 },
 		{ 0, 0 }
 	};
diff --git a/src/gallium/drivers/r300/compiler/radeon_program_alu.c b/src/gallium/drivers/r300/compiler/radeon_program_alu.c
index 5178da1f1c8..3a2aecf71e2 100644
--- a/src/gallium/drivers/r300/compiler/radeon_program_alu.c
+++ b/src/gallium/drivers/r300/compiler/radeon_program_alu.c
@@ -1185,6 +1185,25 @@ int r300_transform_trig_scale_vertex(struct radeon_compiler *c,
 	return 1;
 }
 
+/**
+ * Replaces DDX/DDY instructions with MOV 0 to avoid using dummy shaders on r300/r400.
+ *
+ * @warning This explicitly changes the form of DDX and DDY!
+ */
+
+int radeonStubDeriv(struct radeon_compiler* c,
+	struct rc_instruction* inst,
+	void* unused)
+{
+	if (inst->U.I.Opcode != RC_OPCODE_DDX && inst->U.I.Opcode != RC_OPCODE_DDY)
+		return 0;
+
+	inst->U.I.Opcode = RC_OPCODE_MOV;
+	inst->U.I.SrcReg[0].Swizzle = RC_SWIZZLE_0000;
+
+	return 1;
+}
+
 /**
  * Rewrite DDX/DDY instructions to properly work with r5xx shaders.
  * The r5xx MDH/MDV instruction provides per-quad partial derivatives.
diff --git a/src/gallium/drivers/r300/compiler/radeon_program_alu.h b/src/gallium/drivers/r300/compiler/radeon_program_alu.h
index d1006827616..6f347d1c9f0 100644
--- a/src/gallium/drivers/r300/compiler/radeon_program_alu.h
+++ b/src/gallium/drivers/r300/compiler/radeon_program_alu.h
@@ -55,6 +55,11 @@ int r300_transform_trig_scale_vertex(
 	struct rc_instruction *inst,
 	void*);
 
+int radeonStubDeriv(
+	struct radeon_compiler * c,
+	struct rc_instruction * inst,
+	void*);
+
 int radeonTransformDeriv(
 	struct radeon_compiler * c,
 	struct rc_instruction * inst,