Mesa (main): radeonsi/sqtt: fix FINISH_DONE / BUSY usage

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Nov 8 17:41:27 UTC 2021


Module: Mesa
Branch: main
Commit: e26dd92957df80fc31627eff5fc9c9453cf3021d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e26dd92957df80fc31627eff5fc9c9453cf3021d

Author: Pierre-Eric Pelloux-Prayer <pierre-eric.pelloux-prayer at amd.com>
Date:   Mon Nov  8 10:51:15 2021 +0100

radeonsi/sqtt: fix FINISH_DONE / BUSY usage

They're using more than a single bit so use the proper mask.

Based on https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13694

Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13696>

---

 src/gallium/drivers/radeonsi/si_sqtt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/gallium/drivers/radeonsi/si_sqtt.c b/src/gallium/drivers/radeonsi/si_sqtt.c
index 44a77dc3a40..a5eb4f5851c 100644
--- a/src/gallium/drivers/radeonsi/si_sqtt.c
+++ b/src/gallium/drivers/radeonsi/si_sqtt.c
@@ -321,7 +321,7 @@ si_emit_thread_trace_stop(struct si_context *sctx,
          radeon_emit(R_008D20_SQ_THREAD_TRACE_STATUS >> 2);  /* register */
          radeon_emit(0);
          radeon_emit(0); /* reference value */
-         radeon_emit(S_008D20_FINISH_DONE(1)); /* mask */
+         radeon_emit(~C_008D20_FINISH_DONE); /* mask */
          radeon_emit(4); /* poll interval */
 
          /* Disable the thread trace mode. */
@@ -334,7 +334,7 @@ si_emit_thread_trace_stop(struct si_context *sctx,
          radeon_emit(R_008D20_SQ_THREAD_TRACE_STATUS >> 2);  /* register */
          radeon_emit(0);
          radeon_emit(0); /* reference value */
-         radeon_emit(S_008D20_BUSY(1)); /* mask */
+         radeon_emit(~C_008D20_BUSY); /* mask */
          radeon_emit(4); /* poll interval */
       } else {
          /* Disable the thread trace mode. */
@@ -347,7 +347,7 @@ si_emit_thread_trace_stop(struct si_context *sctx,
          radeon_emit(R_030CE8_SQ_THREAD_TRACE_STATUS >> 2);  /* register */
          radeon_emit(0);
          radeon_emit(0); /* reference value */
-         radeon_emit(S_030CE8_BUSY(1)); /* mask */
+         radeon_emit(~C_030CE8_BUSY); /* mask */
          radeon_emit(4); /* poll interval */
       }
       radeon_end();



More information about the mesa-commit mailing list