Mesa (main): mesa/st: Disable NV_copy_depth_to_color on non-doubles-capable HW.

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: a68a0c9e1c69d14f210de569ed4d73f3e42857db
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=a68a0c9e1c69d14f210de569ed4d73f3e42857db

Author: Emma Anholt <emma at anholt.net>
Date:   Wed Nov 10 12:10:43 2021 -0800

mesa/st: Disable NV_copy_depth_to_color on non-doubles-capable HW.

The previous doubles check
(https://gitlab.freedesktop.org/mesa/mesa/-/issues/3459) checked that you
didn't have full doubles emulation turned on, but we also need to check
that you have doubles at all (emulated or not) or non-GL4 drivers will
fail.

Reviewed-by: Alyssa Rosenzweig <alyssa at collabora.com>
Reviewed-by: Marek Olšák <marek.olsak at amd.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13743>

---

 src/broadcom/ci/v3d-rpi4-fails.txt        | 5 -----
 src/freedreno/ci/freedreno-a530-fails.txt | 6 +-----
 src/freedreno/ci/freedreno-a630-fails.txt | 7 -------
 src/mesa/state_tracker/st_extensions.c    | 1 +
 src/panfrost/ci/panfrost-g52-fails.txt    | 5 -----
 5 files changed, 2 insertions(+), 22 deletions(-)

diff --git a/src/broadcom/ci/v3d-rpi4-fails.txt b/src/broadcom/ci/v3d-rpi4-fails.txt
index 7fcef91d4e2..97c086fe395 100644
--- a/src/broadcom/ci/v3d-rpi4-fails.txt
+++ b/src/broadcom/ci/v3d-rpi4-fails.txt
@@ -277,11 +277,6 @@ spec at khr_texture_compression_astc@miptree-gles srgb-fp,Fail
 spec at khr_texture_compression_astc@miptree-gles srgb-fp at sRGB decode full precision,Fail
 spec at khr_texture_compression_astc@sliced-3d-miptree-gles srgb-fp,Fail
 spec at khr_texture_compression_astc@sliced-3d-miptree-gles srgb-fp at sRGB decode full precision,Fail
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 0 0x223344ff,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 0 0x76356278,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 1 0x223344ff,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 1 0x76356278,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color,Crash
 spec at nv_image_formats@compiler at declaration-disallow-r16-snorm-2d-array.frag,Fail
 spec at nv_image_formats@compiler at declaration-disallow-r16-snorm-2d-array.vert,Fail
 spec at nv_image_formats@compiler at declaration-disallow-r16-snorm-2d.frag,Fail
diff --git a/src/freedreno/ci/freedreno-a530-fails.txt b/src/freedreno/ci/freedreno-a530-fails.txt
index 0b58e8877ae..14d131d6918 100644
--- a/src/freedreno/ci/freedreno-a530-fails.txt
+++ b/src/freedreno/ci/freedreno-a530-fails.txt
@@ -488,11 +488,7 @@ spec at khr_texture_compression_astc@sliced-3d-miptree-gles srgb,Fail
 spec at khr_texture_compression_astc@sliced-3d-miptree-gles srgb at sRGB decode,Fail
 spec at khr_texture_compression_astc@sliced-3d-miptree-gles srgb-fp,Fail
 spec at khr_texture_compression_astc@sliced-3d-miptree-gles srgb-fp at sRGB decode full precision,Fail
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 0 0x223344ff,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 0 0x76356278,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 1 0x223344ff,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 1 0x76356278,Crash
+
 spec at nv_copy_image@nv_copy_image-formats,Fail
 spec at nv_copy_image@nv_copy_image-formats at Source: GL_DEPTH32F_STENCIL8/Destination: GL_DEPTH32F_STENCIL8,Fail
 spec at oes_egl_image_external_essl3@oes_egl_image_external_essl3,Crash
diff --git a/src/freedreno/ci/freedreno-a630-fails.txt b/src/freedreno/ci/freedreno-a630-fails.txt
index 2844043fc8b..bf8197091c2 100644
--- a/src/freedreno/ci/freedreno-a630-fails.txt
+++ b/src/freedreno/ci/freedreno-a630-fails.txt
@@ -460,13 +460,6 @@ spec at khr_texture_compression_astc@sliced-3d-miptree-gl srgb-fp,Fail
 spec at khr_texture_compression_astc@sliced-3d-miptree-gl srgb-fp at sRGB decode full precision,Fail
 spec at khr_texture_compression_astc@sliced-3d-miptree-gl srgb at sRGB decode,Fail
 
-# "MESA: error: Unhandled ALU op: f2f64"
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 0 0x223344ff,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 0 0x76356278,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 1 0x223344ff,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 1 0x76356278,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color,Crash
-
 spec at oes_egl_image_external_essl3@oes_egl_image_external_essl3 at oes_egl_image_external_essl3_imageLoad,Fail
 spec at oes_egl_image_external_essl3@oes_egl_image_external_essl3 at oes_egl_image_external_essl3_imageStore,Fail
 spec at oes_egl_image_external_essl3@oes_egl_image_external_essl3,Fail
diff --git a/src/mesa/state_tracker/st_extensions.c b/src/mesa/state_tracker/st_extensions.c
index f83a574f6d0..214c38e1349 100644
--- a/src/mesa/state_tracker/st_extensions.c
+++ b/src/mesa/state_tracker/st_extensions.c
@@ -1857,6 +1857,7 @@ void st_init_extensions(struct pipe_screen *screen,
    if (prefer_nir &&
        screen->get_shader_param(screen, PIPE_SHADER_FRAGMENT, PIPE_SHADER_CAP_INTEGERS) &&
        extensions->ARB_stencil_texturing &&
+       screen->get_param(screen, PIPE_CAP_DOUBLES) &&
        !(nir_options->lower_doubles_options & nir_lower_fp64_full_software))
       extensions->NV_copy_depth_to_color = TRUE;
 
diff --git a/src/panfrost/ci/panfrost-g52-fails.txt b/src/panfrost/ci/panfrost-g52-fails.txt
index b827025dc9a..4b15631fb9a 100644
--- a/src/panfrost/ci/panfrost-g52-fails.txt
+++ b/src/panfrost/ci/panfrost-g52-fails.txt
@@ -829,11 +829,6 @@ spec at khr_texture_compression_astc@sliced-3d-miptree-gl hdr at HDR Profile,Fail
 spec at khr_texture_compression_astc@sliced-3d-miptree-gl srgb-fp,Fail
 spec at khr_texture_compression_astc@sliced-3d-miptree-gl srgb-fp at sRGB decode full precision,Fail
 spec at nv_conditional_render@blitframebuffer,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 0 0x223344ff,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 0 0x76356278,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 1 0x223344ff,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color 1 0x76356278,Crash
-spec at nv_copy_depth_to_color@nv_copy_depth_to_color,Crash
 spec at nv_copy_image@nv_copy_image-formats,Fail
 spec at nv_copy_image@nv_copy_image-formats --samples=2,Fail
 spec at nv_copy_image@nv_copy_image-formats --samples=2 at Source: GL_ALPHA8/Destination: GL_ALPHA8,Fail