Mesa (main): freedreno/a6xx: Add some notes about piglit failures.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Nov 12 21:18:34 UTC 2021 

Module: Mesa
Branch: main
Commit: 02079cbb77c2a44215dc683fb49adef9bd804f61
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=02079cbb77c2a44215dc683fb49adef9bd804f61

Author: Emma Anholt <emma at anholt.net>
Date:   Wed Nov 10 13:17:33 2021 -0800

freedreno/a6xx: Add some notes about piglit failures.

Hopefully this helps others save time looking at piglit.

Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13747>

---

 src/freedreno/ci/freedreno-a630-fails.txt | 45 +++++++++++++++++++++++++++++++
 1 file changed, 45 insertions(+)

diff --git a/src/freedreno/ci/freedreno-a630-fails.txt b/src/freedreno/ci/freedreno-a630-fails.txt
index bf8197091c2..df58cfe1c87 100644
--- a/src/freedreno/ci/freedreno-a630-fails.txt
+++ b/src/freedreno/ci/freedreno-a630-fails.txt
@@ -101,10 +101,14 @@ spec at arb_depth_texture@texwrap formats bordercolor-swizzled at GL_DEPTH_COMPONENT32
 # "arb_direct_state_access-gettextureimage-formats: ../src/mesa/main/texstore.c:413: _mesa_texstore_s8_z24: Assertion `srcFormat == GL_DEPTH_STENCIL_EXT || srcFormat == GL_DEPTH_COMPONENT || srcFormat == GL_STENCIL_INDEX' failed."
 spec at arb_direct_state_access@gettextureimage-formats,Crash
 
+# "0 primitives generated:
+#  Incorrect number of prims generated.
+#  Found 0, expected 4"
 spec at arb_direct_state_access@transformfeedback-bufferbase,Fail
 spec at arb_direct_state_access@transformfeedback-bufferbase at general test,Fail
 spec at arb_direct_state_access@transformfeedback-bufferrange,Fail
 spec at arb_direct_state_access@transformfeedback-bufferrange at general test,Fail
+
 spec at arb_es2_compatibility@texwrap formats bordercolor-swizzled,Fail
 spec at arb_es2_compatibility@texwrap formats bordercolor-swizzled at GL_RGB565- swizzled- border color only,Fail
 spec at arb_occlusion_query@occlusion_query_order,Fail
@@ -143,18 +147,35 @@ spec at arb_sample_shading@samplemask 4 at sample mask_in_one,Fail
 spec at arb_shader_storage_buffer_object@array-ssbo-auto-binding,Fail
 spec at arb_shader_storage_buffer_object@linker at instance-matching-shader-storage-blocks-member-array-size-mismatch,Fail
 spec at arb_tessellation_shader@execution at gs-primitiveid-instanced,Fail
+
+# Test bug: https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/601#note_1154259
+# "Failed to link:
+#  error: Too many tessellation control shader atomic counters"
 spec at arb_tessellation_shader@execution at invocation-counting-even,Fail
 spec at arb_tessellation_shader@execution at invocation-counting-odd,Fail
+
+# "ir3_nir_lower_tess.c:585: lower_tess_ctrl_block: Assertion `util_is_power_of_two_nonzero(nir_intrinsic_write_mask(intr) + 1)' failed."
 spec at arb_tessellation_shader@execution at patch-partial-write,Crash
+
+# Test bug: https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/601#note_1154259
+# "Failed to link:
+#  error: Too many tessellation control shader atomic counters"
 spec at arb_tessellation_shader@execution at tcs-output-unmatched,Fail
 spec at arb_tessellation_shader@execution at tcs-primitiveid,Fail
+
 spec at arb_tessellation_shader@execution at tes-no-tcs-primitiveid-instanced,Fail
+
+# Test bug: https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/601#note_1154259
+# "Failed to link:
+#  error: Too many tessellation control shader atomic counters"
 spec at arb_tessellation_shader@execution at tes-primitiveid,Fail
+
 spec at arb_tessellation_shader@execution at tes-read-texture,Fail
 spec at arb_tessellation_shader@execution at tess_with_geometry,Fail
 spec at arb_tessellation_shader@execution at trivial-tess-gs,Fail
 spec at arb_tessellation_shader@execution at trivial-tess-gs_no-gs-inputs,Fail
 spec at arb_tessellation_shader@execution at trivial-tess-gs_no-tes-inputs,Fail
+
 spec at arb_tessellation_shader@execution at variable-indexing@tcs-input-array-float-index-rd,Crash
 spec at arb_tessellation_shader@execution at variable-indexing@tcs-input-array-vec2-index-rd,Crash
 spec at arb_tessellation_shader@execution at variable-indexing@tcs-input-array-vec3-index-rd,Crash
@@ -165,11 +186,15 @@ spec at arb_tessellation_shader@execution at variable-indexing@tes-input-array-float-i
 spec at arb_tessellation_shader@execution at variable-indexing@tes-input-array-vec2-index-rd,Crash
 spec at arb_tessellation_shader@execution at variable-indexing@tes-input-array-vec3-index-rd,Crash
 spec at arb_tessellation_shader@execution at variable-indexing@tes-input-array-vec4-index-rd,Crash
+
+# "ir3_nir_lower_tess.c:585: lower_tess_ctrl_block: Assertion `util_is_power_of_two_nonzero(nir_intrinsic_write_mask(intr) + 1)' failed."
 spec at arb_tessellation_shader@execution at vertex-partial-write,Crash
+
 spec at arb_tessellation_shader@execution at vs-tes-max-in-out-components,Fail
 spec at arb_tessellation_shader@execution at vs-tes-tessinner-tessouter-inputs-quads,Fail
 spec at arb_tessellation_shader@execution at vs-tes-tessinner-tessouter-inputs-tris,Fail
 spec at arb_tessellation_shader@execution at vs-tes-vertex,Fail
+
 spec at arb_texture_compression_bptc@texwrap formats bordercolor-swizzled,Fail
 spec at arb_texture_compression_bptc@texwrap formats bordercolor-swizzled at GL_COMPRESSED_RGBA_BPTC_UNORM- swizzled- border color only,Fail
 spec at arb_texture_compression_bptc@texwrap formats bordercolor-swizzled at GL_COMPRESSED_RGB_BPTC_SIGNED_FLOAT- swizzled- border color only,Fail
@@ -213,7 +238,11 @@ spec at arb_texture_rg@texwrap formats-int bordercolor-swizzled at GL_RG8UI- swizzled-
 spec at arb_texture_view@rendering-layers-image,Fail
 spec at arb_texture_view@rendering-layers-image at layers rendering of image1DArray,Fail
 spec at arb_timer_query@timestamp-get,Fail
+
+# "Expected 1 primitives written, got 0"
+# Note: no FS, rasterizer discard enabled.
 spec at arb_transform_feedback3@arb_transform_feedback3-ext_interleaved_two_bufs_vs,Fail
+
 spec at arb_transform_feedback3@gl_skipcomponents1-1,Fail
 spec at arb_transform_feedback3@gl_skipcomponents1234,Fail
 spec at arb_transform_feedback3@gl_skipcomponents1-2,Fail
@@ -360,6 +389,11 @@ spec at glsl-1.50@execution at compatibility@clipping at gs-clip-vertex-homogeneity,Fail
 spec at glsl-1.50@execution at compatibility@clipping at gs-clip-vertex-primitives-lines,Fail
 spec at glsl-1.50@execution at compatibility@clipping at gs-clip-vertex-primitives-points,Fail
 spec at glsl-1.50@execution at compatibility@clipping at gs-clip-vertex-primitives-triangle-strip,Fail
+
+# The precompile without UCP lowering triggers an assertion failure:
+# "shader_io_get_unique_index: Assertion `!"illegal slot in get unique index\n"'
+# failed." We shouldn't crash if clipvertex is written without actually doing
+# clipping, we should just drop the output on the floor.
 spec at glsl-1.50@execution at compatibility@clipping at vs-gs-clip-vertex-const-accept,Crash
 spec at glsl-1.50@execution at compatibility@clipping at vs-gs-clip-vertex-const-reject,Crash
 spec at glsl-1.50@execution at compatibility@clipping at vs-gs-clip-vertex-different-from-position,Crash
@@ -367,13 +401,21 @@ spec at glsl-1.50@execution at compatibility@clipping at vs-gs-clip-vertex-enables,Crash
 spec at glsl-1.50@execution at compatibility@clipping at vs-gs-clip-vertex-equal-to-position,Crash
 spec at glsl-1.50@execution at compatibility@clipping at vs-gs-clip-vertex-homogeneity,Crash
 spec at glsl-1.50@execution at compatibility@clipping at vs-gs-clip-vertex-primitives-triangle-strip,Crash
+
+# "src/freedreno/ir3/ir3_shader.h:864:ir3_find_output: Assertion `0' failed."
+# Reading undefined vertex outputs should be undefined, not crash.
 spec at glsl-1.50@execution at compatibility@gs-clamp-vertex-color,Crash
 spec at glsl-1.50@execution at compatibility@gs-ff-frag,Crash
+
 spec at glsl-1.50@execution at compatibility@gs-texcoord-array-2,Fail
 spec at glsl-1.50@execution at compatibility@gs-texcoord-array,Fail
+
+# "ir3_nir_lower_tess.c:111: shader_io_get_unique_index: Assertion `!"illegal slot in get unique index\n"' failed."
+# I think on VARYING_SLOT_COL0 from the VS.
 spec at glsl-1.50@execution at compatibility@vs-gs-ff-frag,Crash
 spec at glsl-1.50@execution at compatibility@vs-gs-texcoord-array-2,Crash
 spec at glsl-1.50@execution at compatibility@vs-gs-texcoord-array,Crash
+
 spec at glsl-1.50@execution at geometry@end-primitive 0,Fail
 spec at glsl-1.50@execution at geometry@primitive-id-restart gl_line_loop ffs,Fail
 spec at glsl-1.50@execution at geometry@primitive-id-restart gl_line_loop other,Fail
@@ -414,7 +456,10 @@ spec at glsl-1.50@execution at geometry@tri-strip-ordering-with-prim-restart gl_triang
 spec at glsl-1.50@execution at geometry@tri-strip-ordering-with-prim-restart gl_triangle_strip other,Fail
 spec at glsl-1.50@execution at primitive-id-no-gs-quads,Fail
 spec at glsl-1.50@execution at primitive-id-no-gs-quad-strip,Fail
+
+# "failed assert: so->outputs_count < ARRAY_SIZE(so->outputs)"
 spec at glsl-1.50@execution at variable-indexing@gs-output-array-vec4-index-wr,Crash
+
 spec at glsl-1.50@gs-max-output-components,Fail
 spec at intel_performance_query@intel_performance_query-issue_2235,Fail
 spec at khr_texture_compression_astc@array-gl at 12x12 Block Dim,Fail

More information about the mesa-commit mailing list