Mesa (main): ac/rgp: Initialize clock_calibration with memset.

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: 008f5a127cdee30f774a000ad493369a7dcd366a
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=008f5a127cdee30f774a000ad493369a7dcd366a

Author: Vinson Lee <vlee at freedesktop.org>
Date:   Sat Nov 13 11:50:07 2021 -0800

ac/rgp: Initialize clock_calibration with memset.

Fix defect reported by Coverity Scan.

Uninitialized scalar variable (UNINIT)
uninit_use_in_call: Using uninitialized value clock_calibration.
Field clock_calibration.reserved is uninitialized when calling
fwrite.

Fixes: 1ee85e8babe ("ac/rgp: add support for clock calibration")
Suggested-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13783>

---

 src/amd/common/ac_rgp.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/src/amd/common/ac_rgp.c b/src/amd/common/ac_rgp.c
index 24ea488cd5b..3cd81b40e6a 100644
--- a/src/amd/common/ac_rgp.c
+++ b/src/amd/common/ac_rgp.c
@@ -1145,6 +1145,7 @@ static void ac_sqtt_dump_data(struct radeon_info *rad_info,
       list_for_each_entry_safe(struct rgp_clock_calibration_record, record,
                                &rgp_clock_calibration->record, list) {
          struct sqtt_file_chunk_clock_calibration clock_calibration;
+         memset(&clock_calibration, 0, sizeof(clock_calibration));
 
          ac_sqtt_fill_clock_calibration(&clock_calibration, num_records);