Mesa (main): crocus: drop redundant unlikely's around INTEL_DEBUG
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Oct 1 08:09:59 UTC 2021
Module: Mesa
Branch: main
Commit: f7f5062f097a0a33d9736974629712257c3aeffc
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f7f5062f097a0a33d9736974629712257c3aeffc
Author: Marcin Ślusarz <marcin.slusarz at intel.com>
Date: Thu Sep 30 13:31:11 2021 +0200
crocus: drop redundant unlikely's around INTEL_DEBUG
They are not needed since 4015e1876a77162e3444eeaa29a0dfbc47efe90e.
Signed-off-by: Marcin Ślusarz <marcin.slusarz at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13115>
---
src/gallium/drivers/crocus/crocus_batch.c | 5 ++---
src/gallium/drivers/crocus/crocus_draw.c | 4 ++--
src/gallium/drivers/crocus/crocus_program.c | 2 +-
src/gallium/drivers/crocus/crocus_screen.c | 2 +-
src/gallium/drivers/crocus/crocus_state.c | 6 +++---
5 files changed, 9 insertions(+), 10 deletions(-)
diff --git a/src/gallium/drivers/crocus/crocus_batch.c b/src/gallium/drivers/crocus/crocus_batch.c
index e4e132fd11a..4c5d85993aa 100644
--- a/src/gallium/drivers/crocus/crocus_batch.c
+++ b/src/gallium/drivers/crocus/crocus_batch.c
@@ -940,8 +940,7 @@ _crocus_batch_flush(struct crocus_batch *batch, const char *file, int line)
finish_growing_bos(&batch->state);
int ret = submit_batch(batch);
- if (unlikely(INTEL_DEBUG &
- (DEBUG_BATCH | DEBUG_SUBMIT | DEBUG_PIPE_CONTROL))) {
+ if (INTEL_DEBUG & (DEBUG_BATCH | DEBUG_SUBMIT | DEBUG_PIPE_CONTROL)) {
int bytes_for_commands = crocus_batch_bytes_used(batch);
int second_bytes = 0;
if (batch->command.bo != batch->exec_bos[0]) {
@@ -985,7 +984,7 @@ _crocus_batch_flush(struct crocus_batch *batch, const char *file, int line)
util_dynarray_clear(&batch->exec_fences);
- if (unlikely(INTEL_DEBUG & DEBUG_SYNC)) {
+ if (INTEL_DEBUG & DEBUG_SYNC) {
dbg_printf("waiting for idle\n");
crocus_bo_wait_rendering(batch->command.bo); /* if execbuf failed; this is a nop */
}
diff --git a/src/gallium/drivers/crocus/crocus_draw.c b/src/gallium/drivers/crocus/crocus_draw.c
index 68e3a1c40eb..baa42fb8643 100644
--- a/src/gallium/drivers/crocus/crocus_draw.c
+++ b/src/gallium/drivers/crocus/crocus_draw.c
@@ -405,7 +405,7 @@ crocus_draw_vbo(struct pipe_context *ctx,
/* We can't safely re-emit 3DSTATE_SO_BUFFERS because it may zero the
* write offsets, changing the behavior.
*/
- if (unlikely(INTEL_DEBUG & DEBUG_REEMIT)) {
+ if (INTEL_DEBUG & DEBUG_REEMIT) {
ice->state.dirty |= CROCUS_ALL_DIRTY_FOR_RENDER & ~CROCUS_DIRTY_GEN7_SO_BUFFERS;
ice->state.stage_dirty |= CROCUS_ALL_STAGE_DIRTY_FOR_RENDER;
}
@@ -484,7 +484,7 @@ crocus_launch_grid(struct pipe_context *ctx, const struct pipe_grid_info *grid)
if (!crocus_check_conditional_render(ice))
return;
- if (unlikely(INTEL_DEBUG & DEBUG_REEMIT)) {
+ if (INTEL_DEBUG & DEBUG_REEMIT) {
ice->state.dirty |= CROCUS_ALL_DIRTY_FOR_COMPUTE;
ice->state.stage_dirty |= CROCUS_ALL_STAGE_DIRTY_FOR_COMPUTE;
}
diff --git a/src/gallium/drivers/crocus/crocus_program.c b/src/gallium/drivers/crocus/crocus_program.c
index eccf7bff917..3bd46d04f28 100644
--- a/src/gallium/drivers/crocus/crocus_program.c
+++ b/src/gallium/drivers/crocus/crocus_program.c
@@ -951,7 +951,7 @@ crocus_setup_binding_table(const struct intel_device_info *devinfo,
}
bt->size_bytes = next * 4;
- if (unlikely(INTEL_DEBUG & DEBUG_BT)) {
+ if (INTEL_DEBUG & DEBUG_BT) {
crocus_print_binding_table(stderr, gl_shader_stage_name(info->stage), bt);
}
diff --git a/src/gallium/drivers/crocus/crocus_screen.c b/src/gallium/drivers/crocus/crocus_screen.c
index c427fff0121..e937e7986fd 100644
--- a/src/gallium/drivers/crocus/crocus_screen.c
+++ b/src/gallium/drivers/crocus/crocus_screen.c
@@ -694,7 +694,7 @@ crocus_shader_perf_log(void *data, unsigned *id, const char *fmt, ...)
va_list args;
va_start(args, fmt);
- if (unlikely(INTEL_DEBUG & DEBUG_PERF)) {
+ if (INTEL_DEBUG & DEBUG_PERF) {
va_list args_copy;
va_copy(args_copy, args);
vfprintf(stderr, fmt, args_copy);
diff --git a/src/gallium/drivers/crocus/crocus_state.c b/src/gallium/drivers/crocus/crocus_state.c
index f142a7187ec..632cddbbb2f 100644
--- a/src/gallium/drivers/crocus/crocus_state.c
+++ b/src/gallium/drivers/crocus/crocus_state.c
@@ -771,12 +771,12 @@ crocus_calculate_urb_fence(struct crocus_batch *batch, unsigned csize,
exit(1);
}
- if (unlikely(INTEL_DEBUG & (DEBUG_URB|DEBUG_PERF)))
+ if (INTEL_DEBUG & (DEBUG_URB|DEBUG_PERF))
fprintf(stderr, "URB CONSTRAINED\n");
}
done:
- if (unlikely(INTEL_DEBUG & DEBUG_URB))
+ if (INTEL_DEBUG & DEBUG_URB)
fprintf(stderr,
"URB fence: %d ..VS.. %d ..GS.. %d ..CLP.. %d ..SF.. %d ..CS.. %d\n",
ice->urb.vs_start,
@@ -1197,7 +1197,7 @@ emit_l3_state(struct crocus_batch *batch, bool compute)
compute ? batch->screen->l3_config_cs : batch->screen->l3_config_3d;
setup_l3_config(batch, cfg);
- if (unlikely(INTEL_DEBUG & DEBUG_L3)) {
+ if (INTEL_DEBUG & DEBUG_L3) {
intel_dump_l3_config(cfg, stderr);
}
}
More information about the mesa-commit
mailing list