Mesa (main): anv: remove a format assert when setting up attachments

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Oct 1 10:12:34 UTC 2021


Module: Mesa
Branch: main
Commit: 8cc4e0b0c4faf3a09d61fa5376ddbde1dcb491c0
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=8cc4e0b0c4faf3a09d61fa5376ddbde1dcb491c0

Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Tue Sep 28 13:20:53 2021 +0300

anv: remove a format assert when setting up attachments

There are exceptions in spec where the framebuffer image format and
format given for render pass attachment may differ. This happens in
particular when subpass has resolve attachment that might resolve
only depth from a combined depth+stencil format. There the formats do
not need to match but be 'compatible' with each other.

As example using VK_FORMAT_D32_SFLOAT format is considered compatible
when actual framebuffer format is VK_FORMAT_D32_SFLOAT_S8_UINT.

Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Sagar Ghuge <sagar.ghuge at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13082>

---

 src/intel/vulkan/genX_cmd_buffer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c
index a69236baa9b..75c33c38cbe 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src/intel/vulkan/genX_cmd_buffer.c
@@ -1614,7 +1614,6 @@ genX(cmd_buffer_setup_attachments)(struct anv_cmd_buffer *cmd_buffer,
             att_state->clear_value = begin->pClearValues[i];
 
          struct anv_image_view *iview = state->attachments[i].image_view;
-         anv_assert(iview->vk.format == pass_att->format);
 
          const uint32_t num_layers = iview->planes[0].isl.array_len;
          att_state->pending_clear_views = (1 << num_layers) - 1;



More information about the mesa-commit mailing list