Mesa (main): radv: remove useless loads_dynamic_offsets when emitting push constants

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Oct 4 11:51:40 UTC 2021


Module: Mesa
Branch: main
Commit: 75e5795d4161edb34332fec204c2fc8e66989a23
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=75e5795d4161edb34332fec204c2fc8e66989a23

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Tue Sep 28 14:30:53 2021 +0200

radv: remove useless loads_dynamic_offsets when emitting push constants

It's always TRUE if loads_push_constants is TRUE.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13170>

---

 src/amd/vulkan/radv_cmd_buffer.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c
index fc65cdd7a59..94618eb3fb0 100644
--- a/src/amd/vulkan/radv_cmd_buffer.c
+++ b/src/amd/vulkan/radv_cmd_buffer.c
@@ -2870,7 +2870,6 @@ radv_flush_constants(struct radv_cmd_buffer *cmd_buffer, VkShaderStageFlags stag
          continue;
 
       need_push_constants |= shader->info.loads_push_constants;
-      need_push_constants |= shader->info.loads_dynamic_offsets;
 
       uint8_t base = shader->info.base_inline_push_consts;
       uint8_t count = shader->info.num_inline_push_consts;



More information about the mesa-commit mailing list