Mesa (staging/21.2): 24 new commits
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Oct 6 22:58:21 UTC 2021
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b9c1d7c96dc332bd34f1dfcf2f248d7660f96ffc
Author: Connor Abbott <cwabbott0 at gmail.com>
Date: Wed Oct 6 12:55:23 2021 +0200
ir3: Use source in ir3_output_conv_src_type()
This was incorrectly converted when splitting the regs array. Noticed by
inspection.
Fixes: d3e08327cf8 ("ir3/core: Switch to srcs/dsts arrays")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13220>
(cherry picked from commit 0209311c6e8aaed075f6f519706122087e6c33eb)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b8c9d9268eece7bf66471a53aeb92141e5a1fa69
Author: Dave Airlie <airlied at redhat.com>
Date: Wed Oct 6 17:13:46 2021 +1000
device_select: close dri3 fd after using it.
This can leak and causes crashes in some CTS test groups
dEQP-VK.wsi.xcb.incremental_present*
Fixes: 9bc5b2d169d3 ("vulkan: add initial device selection layer. (v6.1)")
Reviewed-by: Michel Dänzer <mdaenzer at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13215>
(cherry picked from commit ab1c888c8d6505d17bfd6a1117c5e77d4f4ac337)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f78e5086a340d2a7efaa1361616ca86138ab7608
Author: Emma Anholt <emma at anholt.net>
Date: Tue Oct 5 12:33:15 2021 -0700
i915g: Check for the scanout-layout conditions before setting level info.
Fixes leaks (release) or assertion failures (debug) on allocating small
scanout resources, when falling through to the non-scanout-specific layout
code, which became more common as of ad50b47a14e9 ("gbm: assume
USE_SCANOUT in create_with_modifiers").
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13202>
(cherry picked from commit 60f464bbce963704290a793c2b9637f7ed3aded3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=cfacc7a11ba575b20a90675d96544bbd7c50d5bd
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date: Mon Sep 27 16:51:32 2021 -0400
panfrost: Fix off-by-one in varying count assert
We want to assert that the number of varyings (the count) is at most the
the maximum count. This is <=, not <, with the assertion previously
failing for exactly the maximum.
Fixes: 2c2cf0ecfe6 ("panfrost: Streamline varying linking code")
Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13070>
(cherry picked from commit 9c8311b737935e6adcab25b16808da2ae5548288)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d6c75bfa02d696bf2b91b1b4f979efaa8069f1d9
Author: Alyssa Rosenzweig <alyssa at collabora.com>
Date: Mon Sep 27 16:48:33 2021 -0400
panfrost: Move special_varying to compiler definitions
The number of special varyings on midgard can influence how much space
we need to allocate for varyings in the compiler ABI. Move the enum so
we can get access it.
No functional change. This is cc stable purely so the following patches
can be backported.
Signed-off-by: Alyssa Rosenzweig <alyssa at collabora.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13070>
(cherry picked from commit 00b05290613cedf487c74cbbb661f959c0efd6fc)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b8781575ca84d3a7ca173a07627c5dabaa55569a
Author: Pavel Asyutchenko <sventeam at yandex.ru>
Date: Thu Sep 2 21:11:04 2021 +0300
llvmpipe: fix crash when doing FB fetch + gl_FragDepth write in one shader
Reproducible by piglit test from this MR:
https://gitlab.freedesktop.org/mesa/piglit/-/merge_requests/576
Signed-off-by: Pavel Asyutchenko <sventeam at yandex.ru>
Reviewed-by: Dave Airlie <airlied at redhat.com>
Cc: mesa-stable
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12705>
(cherry picked from commit 7ffb1522767d4f502141273a89bba125f5a451ea)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=966a515e8afea9741f4bf368c55922e8c139aacc
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Wed Oct 6 10:04:56 2021 -0700
.pick_status.json: Update to 729991e09cd28550001ae63710ab929d95b115bc
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=3dea42b3404139fd8f253f38ed17f60da9cfd441
Author: Dave Airlie <airlied at redhat.com>
Date: Tue Oct 5 12:11:26 2021 +1000
crocus/query: don't loop on ready status after gpu hang.
When a GPU hang occurs, the syncobj will eventually timeout,
if this is a wait, just set ready, so things will continue.
This matches 965 behaviour better.
Fixes: c282a082bef0 ("crocus/query: poll the syncobj in the no wait situation")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13188>
(cherry picked from commit 0a592db57360a7847ca9c57e47f6200a2992f2e9)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=0da4403f2c4a5b3232bb7d6094823d117e9875ec
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Wed Sep 29 10:22:14 2021 +0300
anv: enable UBO indexing
We added support but didn't expose it through the API.
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Fixes: b704d03efd4767 ("anv: Do UBO loads with global addresses for bindless")
Closes: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5426
Acked-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13097>
(cherry picked from commit 710393b3aa4a99d446db0c41ef23eb44332332b4)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=e46efe260dcce93e5a6488ec0bc76f130a87ec38
Author: Icecream95 <ixn at disroot.org>
Date: Fri Jul 23 12:14:32 2021 +1200
pan/mdg: Use the correct swizzle for condition moves
Fixes: 70072a20e00 ("pan/midgard: Refactor swizzles")
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13173>
(cherry picked from commit ad60fffd49db1c1a1089e8dd697a48c3537504cf)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=76ffda7c855ccfda142e8390201fc1b96a98a213
Author: Filip Gawin <filip.gawin at zoho.com>
Date: Fri Oct 1 11:20:27 2021 +0200
r300: implement forgotten tgsi's cases of textures
Fixes: d0c398a8 ("r300g: Use radeon compiler for fragment programs")
Reviewed-by: Emma Anholt <emma at anholt.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13135>
(cherry picked from commit b47017192b0738d93512e41120ee5eace25ad4a3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7c6eb3396d4fe170c5de59a88c02216919f0469a
Author: Vasily Khoruzhick <anarsoul at gmail.com>
Date: Thu Sep 30 19:31:09 2021 -0700
lima: split_load_input: don't split unaligned vec2
Mali4x0 can't fetch unaligned vec2 (i.e. .yz), so don't split it.
Fixes: 6dd0ad66dedc ("lima/ppir: add NIR pass to split varying loads")
Reviewed-by: Erico Nunes <nunes.erico at gmail.com>
Signed-off-by: Vasily Khoruzhick <anarsoul at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13131>
(cherry picked from commit 5db5ff58b73de749378223ae80f542f832ec5461)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=202f0363acfe8917cd0f4d9dbf5e559528bcd492
Author: Timur Kristóf <timur.kristof at gmail.com>
Date: Fri Oct 1 12:29:24 2021 +0200
aco: Fix determining whether any culling is enabled.
Use 0xB instead of 0x00FFFFFF - this allows to jump over the culling
code when no actual culling is enabled but the ngg_cull_face_is_ccw
flag is set.
Fixes: 182d9b1e6072bec190cf0a52e9d93dbbdbaa850d
Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13129>
(cherry picked from commit 6ca66808b5ab60b3a3177987a17b6a8803cb1d1d)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=88ace152c46d799b900af23fd50ece0ab4a5b2d3
Author: Timur Kristóf <timur.kristof at gmail.com>
Date: Thu Sep 30 23:11:05 2021 +0200
aco: Fix small primitive precision.
This is a mistake. It should use ngg_culling_settings
instead of ngg_gs_state.
Fixes: 182d9b1e6072bec190cf0a52e9d93dbbdbaa850d
Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13129>
(cherry picked from commit c13a8d20f7b2598dd98e0e9c252617dd55a42523)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=6999aec3e645f275257a267247c58e1a18e05505
Author: Kai Wasserbäch <kai at dev.carbon-project.org>
Date: Thu Jul 22 07:42:12 2021 +0200
gallivm: fix FTBFS on i386 with LLVM >= 13, StackAlignmentOverride is gone
Use the newly added wrapper lp_set_module_stack_alignment_override() to
achieve the same end result.
Signed-off-by: Kai Wasserbäch <kai at dev.carbon-project.org>
Closes: mesa/mesa#4906
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11940>
(cherry picked from commit 3a2d317b996f57647da23de7876142be4b9b71f3)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=50df76b7c7c52c1a6a4ede2136aa422635a58b54
Author: Kai Wasserbäch <kai at dev.carbon-project.org>
Date: Thu Jul 22 07:34:09 2021 +0200
gallivm: add new wrapper around Module::setOverrideStackAlignment()
We need it in the next commit to replace setting the stack alignment on
i386 with LLVM >= 13 through the TargetOption::StackAlignmentOverride,
which was removed in the upstream commit
<https://github.com/llvm/llvm-project/commit/3787ee457173c3612aac4c9b1a2b6d6ab0202616>.
Unfortunately Module::setOverrideStackAlignment() is not available
through the C API and we need to wrap it ourselves.
Signed-off-by: Kai Wasserbäch <kai at dev.carbon-project.org>
Reference: mesa/mesa#4906
Reviewed-by: Roland Scheidegger <sroland at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/11940>
(cherry picked from commit c1b4c64a28d9fc093229eab91a3a7fc4cb4fe29a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=c62f32f27f5caa69241e5136c221312e3caa99c0
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Tue Oct 5 10:30:15 2021 -0700
.pick_status.json: Update to d2543658ef6fe0ad59af217a09a931d3b6174a43
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=7f8c5eae38a4b0d3edb9714ae772ec2e5e3b4144
Author: Emma Anholt <emma at anholt.net>
Date: Fri Sep 24 10:04:49 2021 -0700
gallium/dri: Make YUV formats we're going to emulate external-only.
If we're going to have to bind them as separate planes with colorspace
conversion for sampling on the frontend, then we need to report that
they're only for external-image samplers, otherwise the lowering won't be
applied.
Fixes: 4e3a7dcf ("gallium: enable EGL_EXT_image_dma_buf_import_modifiers unconditionally")
Reviewed-by: Jose Maria Casanova Crespo <jmcasanova at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13038>
(cherry picked from commit c530510514633236138b2b2501c135d34569b1bf)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b40c0f1bc22b8cf693f02264a3d7f59fb22e7a9d
Author: Chia-I Wu <olvaffe at gmail.com>
Date: Wed Sep 29 20:36:46 2021 -0700
radv: plug leaks in radv_device_init_accel_struct_build_state
Fixes: 0dad88b4694 ("radv: Implement device-side BVH building.")
Signed-off-by: Chia-I Wu <olvaffe at gmail.com>
Reviewed-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13110>
(cherry picked from commit e57b80f283dab572d271f00f99cbb61970cd75b2)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=264e770b828386f8b1dc191d3743595a032914a6
Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date: Wed Sep 29 11:28:01 2021 +0200
radv: fix adjusting the frag coord when RADV_FORCE_VRS is enabled
force_vrs was always RADV_FORCE_VRS_NONE at that point and the
hw workaround was never applied.
Found by inspection.
Cc: mesa-stable
Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13098>
(cherry picked from commit 0c88c5cdc436fecc777b8635fd57fe7e194a5e0a)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a30bee6a14017b65549b51968493234b372611a9
Author: Qiang Yu <yuq825 at gmail.com>
Date: Fri Sep 24 15:47:50 2021 +0800
loader/dri3: fix swap out of order when changing swap interval
This fixes SPECVIEWPERF13 creo test case hang:
1. Client: send present pixmap request (serial=1) when swap_interval==1
and increase send_sbc=1
2. Server: pend the request before vblank arrives
3. Client: set swap_interval=0 (so set XCB_PRESENT_OPTION_ASYNC),
send another present pixmap request (serial=2), increase send_sbc=2
4. Server: handle the async request immediately and send complete event
(serial=2)
5. Client: handle the event and set recv_sbc=event->serial=2
6. Server: vblank arrives so handle pending request and send complete
event (serial=1)
7. Client: handle the event and set recv_sbc=event->serial=1
8. Client: someone call loader_dri3_swapbuffer_barrier() and waiting
on recv_sbc==send_sbc, but no one will set recv_sbc=2 again
So basically it's caused by swap happens out of order. This commit
fixes the problem by waiting on the pending sync swaps all done when
switching to async mode, so move 6&7 before 3.
Attach the xtrace when problem happens:
005:<:003e: 72: Present-Request(148,1): Pixmap window=0x03000002 pixmap=0x0300000b serial=1 valid=0x00000000 update=0x00000000 x_off=0 y_off=0 target_crtc=0x00000000 wait_fence=0x00000000 idle_fence=0x0300000c options=0 target_msc=4294967296 divisor=0 remainder=0 notifies=;
...
005:<:0041: 72: Present-Request(148,1): Pixmap window=0x03000002 pixmap=0x03000011 serial=2 valid=0x00000000 update=0x00000000 x_off=0 y_off=0 target_crtc=0x00000000 wait_fence=0x00000000 idle_fence=0x03000012 options=Async target_msc=0 divisor=0 remainder=0 notifies=;
005:>:0041: Event Generic(35) Present(148) IdleNotify(2) event=0x03000006 window=0x03000002 serial=2 pixmap=0x03000011 idle_fence=0x03000012
005:>:0041: Event Generic(35) Present(148) CompleteNotify(1) kind=Pixmap(0x00) mode=Copy(0x00) event=0x03000006 window=0x03000002 serial=2 ust=7505462213117739011 msc=3565046193979392
005:>:0041: Event Generic(35) Present(148) IdleNotify(2) event=0x03000006 window=0x03000002 serial=1 pixmap=0x0300000b idle_fence=0x0300000c
005:>:0041: Event Generic(35) Present(148) CompleteNotify(1) kind=Pixmap(0x00) mode=Copy(0x00) event=0x03000006 window=0x03000002 serial=1 ust=7505533793042694147 msc=3565050488946688
Cc: mesa-stable
Reviewed-by: Michel Dänzer <mdaenzer at redhat.com>
Signed-off-by: Qiang Yu <yuq825 at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13019>
(cherry picked from commit e55e61758c704f79fa6634bfdcd7563330d68060)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=51785811d164b2542e4667e1fef0b9572d099599
Author: Jason Ekstrand <jason at jlekstrand.net>
Date: Wed Sep 29 08:15:24 2021 -0500
vulkan/shader_module: Fix the lifetime of temporary shader modules
The vk_shader_module_handle_from_nir() macro was constructing a
temporary vk_shader_module and passing it through
vk_shader_module_to_handle(). Since this is a function and not a macro,
it means that the lifetime of the temporary vk_shader_module will end
once the to_handle() function is called. Technically, this is a
use-after-free. I really don't know why no one has been bitten by this
yet....
Fixes: a41e98ddcae0 "vk/util: add a util macro for initializing stack..."
Reviewed-by: Alejandro Piñeiro <apinheiro at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13101>
(cherry picked from commit 24637a6579303a6b4f85001f33943c6004af8c50)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=384fe7c76e3920419b203e11f98d295680a977df
Author: Vinson Lee <vlee at freedesktop.org>
Date: Sun Aug 15 02:14:41 2021 -0700
pps: Avoid duplicate elements in with_datasources array.
Setting -Dperfetto=true and -Ddatasources=intel,panfrost to the
meson command line resulted in duplicate elements.
Fixes: 92180a43763 ("pps: Intel pps driver")
Fixes: 513d1baaea5 ("pps: Panfrost pps driver")
Signed-off-by: Vinson Lee <vlee at freedesktop.org>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12379>
(cherry picked from commit 77d2bdb0a274d3bfccb63585c313ff7033a5656b)
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=1c5227b89ded66f1eebea379899ddbbe44bf35c0
Author: Dylan Baker <dylan.c.baker at intel.com>
Date: Fri Oct 1 08:57:16 2021 -0700
.pick_status.json: Update to fb8f532ea1bbd9c959e0f59c652347e435a71f91
More information about the mesa-commit
mailing list