Mesa (main): anv/android: fix parameters given for vk_common_QueueSubmit

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Oct 13 06:19:00 UTC 2021


Module: Mesa
Branch: main
Commit: 840c79fc9bcba9dfa38107da37a375c18fdcdcc1
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=840c79fc9bcba9dfa38107da37a375c18fdcdcc1

Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Tue Oct 12 11:13:49 2021 +0300

anv/android: fix parameters given for vk_common_QueueSubmit

Common queue submit expects pWaitDstStageMask to be set per each
semaphore (as per Vulkan spec) and crashes if these are not given
properly.

This fixes crashes seen when running vulkan apps on Android.

v2: change the VkPipelineStageFlags given (Lionel)

Fixes: b996fa8efaa4 ("anv: implement VK_KHR_synchronization2")
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Jason Ekstrand <jason at jlekstrand.net>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13305>

---

 src/intel/vulkan/anv_android.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/src/intel/vulkan/anv_android.c b/src/intel/vulkan/anv_android.c
index 94cc09514dc..eef859ae249 100644
--- a/src/intel/vulkan/anv_android.c
+++ b/src/intel/vulkan/anv_android.c
@@ -904,6 +904,9 @@ anv_QueueSignalReleaseImageANDROID(
             .sType = VK_STRUCTURE_TYPE_SUBMIT_INFO,
             .waitSemaphoreCount = 1,
             .pWaitSemaphores = pWaitSemaphores,
+            .pWaitDstStageMask = &(VkPipelineStageFlags) {
+               VK_PIPELINE_STAGE_ALL_COMMANDS_BIT
+            },
       },
       (VkFence) VK_NULL_HANDLE);
    if (result != VK_SUCCESS)



More information about the mesa-commit mailing list