Mesa (main): lavapipe: stop reading renderpass during pipeline creation
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Tue Oct 19 01:31:45 UTC 2021
Module: Mesa
Branch: main
Commit: d103d5bb5dc9e72489de227fa573e049034b6272
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=d103d5bb5dc9e72489de227fa573e049034b6272
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Fri Oct 1 13:48:44 2021 -0400
lavapipe: stop reading renderpass during pipeline creation
this is unnecessary and is going to be annoying in the future
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13349>
---
src/gallium/frontends/lavapipe/lvp_pipeline.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/gallium/frontends/lavapipe/lvp_pipeline.c b/src/gallium/frontends/lavapipe/lvp_pipeline.c
index 36c403d4f47..ef5de756281 100644
--- a/src/gallium/frontends/lavapipe/lvp_pipeline.c
+++ b/src/gallium/frontends/lavapipe/lvp_pipeline.c
@@ -842,12 +842,12 @@ lvp_graphics_pipeline_init(struct lvp_pipeline *pipeline,
bool rasterization_disabled = !dynamic_state_contains(pipeline->graphics_create_info.pDynamicState, VK_DYNAMIC_STATE_RASTERIZER_DISCARD_ENABLE_EXT) &&
pipeline->graphics_create_info.pRasterizationState->rasterizerDiscardEnable;
- LVP_FROM_HANDLE(lvp_render_pass, pass, pipeline->graphics_create_info.renderPass);
if (!dynamic_state_contains(pipeline->graphics_create_info.pDynamicState, VK_DYNAMIC_STATE_COLOR_WRITE_ENABLE_EXT) &&
- !rasterization_disabled && pass->has_color_attachment) {
+ !rasterization_disabled) {
const VkPipelineColorWriteCreateInfoEXT *cw_state =
vk_find_struct_const(pCreateInfo->pColorBlendState, PIPELINE_COLOR_WRITE_CREATE_INFO_EXT);
if (cw_state) {
+ assert(cw_state->attachmentCount <= pipeline->graphics_create_info.pColorBlendState->attachmentCount);
for (unsigned i = 0; i < cw_state->attachmentCount; i++)
if (!cw_state->pColorWriteEnables[i]) {
VkPipelineColorBlendAttachmentState *att = (void*)&pipeline->graphics_create_info.pColorBlendState->pAttachments[i];
More information about the mesa-commit
mailing list