Mesa (staging/21.3): zink: assert compute descriptor key is valid before hashing it

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Oct 21 22:06:02 UTC 2021


Module: Mesa
Branch: staging/21.3
Commit: bca75b943f22cd1d2776f519522709eac8cba68d
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=bca75b943f22cd1d2776f519522709eac8cba68d

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Tue Oct 12 15:16:14 2021 -0400

zink: assert compute descriptor key is valid before hashing it

Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13429>

---

 src/gallium/drivers/zink/zink_descriptors.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/gallium/drivers/zink/zink_descriptors.c b/src/gallium/drivers/zink/zink_descriptors.c
index f1e1ac6306f..dc83c0a8313 100644
--- a/src/gallium/drivers/zink/zink_descriptors.c
+++ b/src/gallium/drivers/zink/zink_descriptors.c
@@ -723,8 +723,10 @@ populate_zds_key(struct zink_context *ctx, enum zink_descriptor_type type, bool
       key->exists[0] = true;
       if (type == ZINK_DESCRIPTOR_TYPES)
          key->state[0] = ctx->dd->push_state[is_compute];
-      else
+      else {
+         assert(ctx->dd->descriptor_states[is_compute].valid[type]);
          key->state[0] = ctx->dd->descriptor_states[is_compute].state[type];
+      }
    } else if (type == ZINK_DESCRIPTOR_TYPES) {
       /* gfx only */
       for (unsigned i = 0; i < ZINK_SHADER_COUNT; i++) {



More information about the mesa-commit mailing list