Mesa (main): nir_to_tgsi: Clean up some unnecessary pointers-to-uregs.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Sep 9 22:23:08 UTC 2021


Module: Mesa
Branch: main
Commit: ed1fb1f03be5e0cb5fb9a36dc0b089f3ff4ee8de
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=ed1fb1f03be5e0cb5fb9a36dc0b089f3ff4ee8de

Author: Emma Anholt <emma at anholt.net>
Date:   Tue Sep  7 17:16:58 2021 -0700

nir_to_tgsi: Clean up some unnecessary pointers-to-uregs.

This was used at one point to do ntt_store_def() or something I think.

Reviewed-by: Rob Clark <robdclark at chromium.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12781>

---

 src/gallium/auxiliary/nir/nir_to_tgsi.c | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/src/gallium/auxiliary/nir/nir_to_tgsi.c b/src/gallium/auxiliary/nir/nir_to_tgsi.c
index 1156a93b166..1794735c040 100644
--- a/src/gallium/auxiliary/nir/nir_to_tgsi.c
+++ b/src/gallium/auxiliary/nir/nir_to_tgsi.c
@@ -690,7 +690,7 @@ ntt_swizzle_for_write_mask(struct ureg_src src, uint32_t write_mask)
                        (write_mask & TGSI_WRITEMASK_W) ? TGSI_SWIZZLE_W : first_chan);
 }
 
-static struct ureg_dst *
+static struct ureg_dst
 ntt_get_ssa_def_decl(struct ntt_compile *c, nir_ssa_def *ssa)
 {
    uint32_t writemask = BITSET_MASK(ssa->num_components);
@@ -703,22 +703,22 @@ ntt_get_ssa_def_decl(struct ntt_compile *c, nir_ssa_def *ssa)
 
    c->ssa_temp[ssa->index] = ureg_writemask(dst, writemask);
 
-   return &c->ssa_temp[ssa->index];
+   return c->ssa_temp[ssa->index];
 }
 
-static struct ureg_dst *
+static struct ureg_dst
 ntt_get_dest_decl(struct ntt_compile *c, nir_dest *dest)
 {
    if (dest->is_ssa)
       return ntt_get_ssa_def_decl(c, &dest->ssa);
    else
-      return &c->reg_temp[dest->reg.reg->index];
+      return c->reg_temp[dest->reg.reg->index];
 }
 
 static struct ureg_dst
 ntt_get_dest(struct ntt_compile *c, nir_dest *dest)
 {
-   struct ureg_dst dst = *ntt_get_dest_decl(c, dest);
+   struct ureg_dst dst = ntt_get_dest_decl(c, dest);
 
    if (!dest->is_ssa) {
       dst.Index += dest->reg.base_offset;
@@ -753,7 +753,7 @@ ntt_store_def(struct ntt_compile *c, nir_ssa_def *def, struct ureg_src src)
       }
    }
 
-   ureg_MOV(c->ureg, *ntt_get_ssa_def_decl(c, def), src);
+   ureg_MOV(c->ureg, ntt_get_ssa_def_decl(c, def), src);
 }
 
 static void



More information about the mesa-commit mailing list