Mesa (main): symbols-check: Fix symbol demangling for Windows

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Sep 16 18:06:23 UTC 2021


Module: Mesa
Branch: main
Commit: 29e3094d1e02bae164fabf73abe3d442b691bb22
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=29e3094d1e02bae164fabf73abe3d442b691bb22

Author: Jesse Natalie <jenatali at microsoft.com>
Date:   Wed Sep 15 14:41:34 2021 -0700

symbols-check: Fix symbol demangling for Windows

Only strip leading underscores if there's also a trailing @
Fixes shared-glapi symbol check for x64

Reviewed-by: Eric Engestrom <eric at engestrom.ch>
Reviewed-by: Emil Velikov <emil.velikov at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/12881>

---

 bin/symbols-check.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/bin/symbols-check.py b/bin/symbols-check.py
index 5ebeb861d12..dd36470d768 100644
--- a/bin/symbols-check.py
+++ b/bin/symbols-check.py
@@ -73,7 +73,7 @@ def get_symbols_dumpbin(dumpbin, lib):
             continue
         symbol_name = fields[3]
         # De-mangle symbols
-        if symbol_name[0] == '_':
+        if symbol_name[0] == '_' and '@' in symbol_name:
             symbol_name = symbol_name[1:].split('@')[0]
         symbols.append(symbol_name)
     return symbols



More information about the mesa-commit mailing list