Mesa (main): spirv: avoid shadowing local variable
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Sep 27 20:09:31 UTC 2021
Module: Mesa
Branch: main
Commit: a17928639dfdd285bbe258f9985a6d8568b51e8a
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a17928639dfdd285bbe258f9985a6d8568b51e8a
Author: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Date: Fri Sep 24 15:16:44 2021 +0300
spirv: avoid shadowing local variable
v2: rename s/eval/elem_val/ (Caio)
Signed-off-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Reviewed-by: Jesse Natalie <jenatali at microsoft.com>
Reviewed-by: Caio Marcelo de Oliveira Filho <caio.oliveira at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13030>
---
src/compiler/spirv/spirv_to_nir.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/src/compiler/spirv/spirv_to_nir.c b/src/compiler/spirv/spirv_to_nir.c
index a400c51c143..64eca17e4eb 100644
--- a/src/compiler/spirv/spirv_to_nir.c
+++ b/src/compiler/spirv/spirv_to_nir.c
@@ -1965,16 +1965,16 @@ vtn_handle_constant(struct vtn_builder *b, SpvOp opcode,
nir_constant **elems = ralloc_array(b, nir_constant *, elem_count);
for (unsigned i = 0; i < elem_count; i++) {
- struct vtn_value *val = vtn_untyped_value(b, w[i + 3]);
+ struct vtn_value *elem_val = vtn_untyped_value(b, w[i + 3]);
- if (val->value_type == vtn_value_type_constant) {
- elems[i] = val->constant;
+ if (elem_val->value_type == vtn_value_type_constant) {
+ elems[i] = elem_val->constant;
} else {
- vtn_fail_if(val->value_type != vtn_value_type_undef,
+ vtn_fail_if(elem_val->value_type != vtn_value_type_undef,
"only constants or undefs allowed for "
"SpvOpConstantComposite");
/* to make it easier, just insert a NULL constant for now */
- elems[i] = vtn_null_constant(b, val->type);
+ elems[i] = vtn_null_constant(b, elem_val->type);
}
}
More information about the mesa-commit
mailing list