Mesa (main): radv: enable VK_EXT_separate_stencil_usage

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Apr 1 07:22:01 UTC 2022


Module: Mesa
Branch: main
Commit: e6d7a6a3b72a95b29bacce4a3a1842144ab9663c
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e6d7a6a3b72a95b29bacce4a3a1842144ab9663c

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Wed Mar 30 13:24:47 2022 +0200

radv: enable VK_EXT_separate_stencil_usage

This extension has been promoted to Vulkan 1.2 which means it has been
silently enabled when we implemented Vulkan 1.2.

Enable it explicitely to make mesamatrix happy and also for consistency.
This extension was designed for potential performance improvements of
MSAA depth/stencil images but it's currently a no-op in RADV.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15665>

---

 docs/features.txt            | 2 +-
 src/amd/vulkan/radv_device.c | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/docs/features.txt b/docs/features.txt
index 68b2396b38a..c21d16ba4d4 100644
--- a/docs/features.txt
+++ b/docs/features.txt
@@ -467,7 +467,7 @@ Vulkan 1.2 -- all DONE: anv, vn
   VK_EXT_host_query_reset                               DONE (anv, lvp, radv, tu, v3dv, vn)
   VK_EXT_sampler_filter_minmax                          DONE (anv/gen9+, lvp, radv, tu, vn)
   VK_EXT_scalar_block_layout                            DONE (anv, lvp, radv/gfx7+, tu, vn)
-  VK_EXT_separate_stencil_usage                         DONE (anv, lvp, tu, vn)
+  VK_EXT_separate_stencil_usage                         DONE (anv, lvp, radv, tu, vn)
   VK_EXT_shader_viewport_index_layer                    DONE (anv, lvp, radv, tu, vn)
 
 Vulkan 1.3 -- all DONE: anv, radv, lvp
diff --git a/src/amd/vulkan/radv_device.c b/src/amd/vulkan/radv_device.c
index 1c66290af87..db5f25ee3e1 100644
--- a/src/amd/vulkan/radv_device.c
+++ b/src/amd/vulkan/radv_device.c
@@ -514,6 +514,7 @@ radv_physical_device_get_supported_extensions(const struct radv_physical_device
       .EXT_sample_locations = device->rad_info.chip_class < GFX10,
       .EXT_sampler_filter_minmax = true,
       .EXT_scalar_block_layout = device->rad_info.chip_class >= GFX7,
+      .EXT_separate_stencil_usage = true,
       .EXT_shader_atomic_float = true,
 #ifdef LLVM_AVAILABLE
       .EXT_shader_atomic_float2 = !device->use_llvm || LLVM_VERSION_MAJOR >= 14,



More information about the mesa-commit mailing list