Mesa (main): v3dv: fix limits for inline uniform blocks

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Apr 4 09:49:13 UTC 2022


Module: Mesa
Branch: main
Commit: 827ef5fba906b593cc009f000d7959aedf380626
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=827ef5fba906b593cc009f000d7959aedf380626

Author: Iago Toral Quiroga <itoral at igalia.com>
Date:   Mon Apr  4 10:51:50 2022 +0200

v3dv: fix limits for inline uniform blocks

We don't support 'Update After Bind', however, the limits for this
model also include the ones without it. See the with or without remark
in the spec below:

"maxPerStageDescriptorUpdateAfterBindInlineUniformBlocks is similar to
 maxPerStageDescriptorInlineUniformBlocks but counts descriptor bindings
 from descriptor sets created with or without the
 VK_DESCRIPTOR_SET_LAYOUT_CREATE_UPDATE_AFTER_BIND_POOL_BIT bit set."

Fixes:
dEQP-VK.api.info.vulkan1p2_limits_validation.ext_inline_uniform_block

Reviewed-by: Juan A. Suarez <jasuarez at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15732>

---

 src/broadcom/vulkan/v3dv_device.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/broadcom/vulkan/v3dv_device.c b/src/broadcom/vulkan/v3dv_device.c
index 4205b718d3c..52b4fa535c1 100644
--- a/src/broadcom/vulkan/v3dv_device.c
+++ b/src/broadcom/vulkan/v3dv_device.c
@@ -1608,8 +1608,10 @@ v3dv_GetPhysicalDeviceProperties2(VkPhysicalDevice physicalDevice,
             MAX_INLINE_UNIFORM_BUFFERS;
          props->maxDescriptorSetInlineUniformBlocks =
             MAX_INLINE_UNIFORM_BUFFERS;
-         props->maxPerStageDescriptorUpdateAfterBindInlineUniformBlocks = 0;
-         props->maxDescriptorSetUpdateAfterBindInlineUniformBlocks = 0;
+         props->maxPerStageDescriptorUpdateAfterBindInlineUniformBlocks =
+            MAX_INLINE_UNIFORM_BUFFERS;
+         props->maxDescriptorSetUpdateAfterBindInlineUniformBlocks =
+            MAX_INLINE_UNIFORM_BUFFERS;
          break;
       }
       case VK_STRUCTURE_TYPE_PHYSICAL_DEVICE_PROVOKING_VERTEX_PROPERTIES_EXT: {



More information about the mesa-commit mailing list