Mesa (main): zink: adds refs to user index buffers when tc is not active

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Apr 7 22:20:40 UTC 2022


Module: Mesa
Branch: main
Commit: fde2c1db88b0d221c67de2b510222abd483859ab
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=fde2c1db88b0d221c67de2b510222abd483859ab

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Thu Apr  7 17:01:00 2022 -0400

zink: adds refs to user index buffers when tc is not active

there are no ref tricks to abuse in this case, so add our own ref

fixes #6273

cc: mesa-stable

Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15807>

---

 src/gallium/drivers/zink/zink_draw.cpp | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/gallium/drivers/zink/zink_draw.cpp b/src/gallium/drivers/zink/zink_draw.cpp
index 74672205354..7dde95a0719 100644
--- a/src/gallium/drivers/zink/zink_draw.cpp
+++ b/src/gallium/drivers/zink/zink_draw.cpp
@@ -531,7 +531,11 @@ zink_draw(struct pipe_context *pctx,
             debug_printf("util_upload_index_buffer() failed\n");
             return;
          }
-         zink_batch_reference_resource_move(batch, zink_resource(index_buffer));
+         /* this will have extra refs from tc */
+         if (screen->threaded)
+            zink_batch_reference_resource_move(batch, zink_resource(index_buffer));
+         else
+            zink_batch_reference_resource(batch, zink_resource(index_buffer));
       } else {
          index_buffer = dinfo->index.resource;
          zink_batch_reference_resource_rw(batch, zink_resource(index_buffer), false);



More information about the mesa-commit mailing list