Mesa (main): v3dv: fix bogus VkDrmFormatModifierProperties2EXT usage

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Apr 8 15:11:19 UTC 2022


Module: Mesa
Branch: main
Commit: 40f0c616e88effbd2089de34f1ec8038f0862d03
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=40f0c616e88effbd2089de34f1ec8038f0862d03

Author: Iago Toral Quiroga <itoral at igalia.com>
Date:   Fri Apr  8 13:48:54 2022 +0200

v3dv: fix bogus VkDrmFormatModifierProperties2EXT usage

The array is allocated for VkDrmFormatModifierPropertiesEXT, so
writring entried with type VkDrmFormatModifierProperties2EXT is
bogus.

It seems this was a mistake added with a change intended to get
rid of VK_OUTARRAY_MAKE, that changed the type of the write by
mistake.

Fixes: 56a2ccf05864 ('v3dv: Stop using VK_OUTARRAY_MAKE()')

Reviewed-by: Juan A. Suarez <jasuarez at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15819>

---

 src/broadcom/vulkan/v3dv_formats.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/broadcom/vulkan/v3dv_formats.c b/src/broadcom/vulkan/v3dv_formats.c
index 6be9969acad..c8f0e8489ac 100644
--- a/src/broadcom/vulkan/v3dv_formats.c
+++ b/src/broadcom/vulkan/v3dv_formats.c
@@ -304,7 +304,7 @@ v3dv_GetPhysicalDeviceFormatProperties2(VkPhysicalDevice physicalDevice,
             }
          }
          if (pFormatProperties->formatProperties.optimalTilingFeatures) {
-            vk_outarray_append_typed(VkDrmFormatModifierProperties2EXT,
+            vk_outarray_append_typed(VkDrmFormatModifierPropertiesEXT,
                                      &out, mod_props) {
                mod_props->drmFormatModifier = DRM_FORMAT_MOD_BROADCOM_UIF;
                mod_props->drmFormatModifierPlaneCount = 1;



More information about the mesa-commit mailing list