Mesa (main): anv: initialize 3DMESH_1D.ExtendedParameter0 when ExtendedParameter0Present

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: 65600a34c251b2005f063e6c2f3012258dc2b513
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=65600a34c251b2005f063e6c2f3012258dc2b513

Author: Marcin Ślusarz <marcin.slusarz at intel.com>
Date:   Fri Apr  8 10:58:33 2022 +0200

anv: initialize 3DMESH_1D.ExtendedParameter0 when ExtendedParameter0Present

When IndirectParameterEnable==true it's not actually used by the hardware,
but if it's not initialized and INTEL_DEBUG=bat is set, then Valgrind complains.

Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15850>

---

 src/intel/vulkan/genX_cmd_buffer.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c
index 4679bca8645..a094c718bcc 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src/intel/vulkan/genX_cmd_buffer.c
@@ -5115,10 +5115,12 @@ emit_indirect_3dmesh_1d(struct anv_batch *batch,
                         bool uses_drawid)
 {
    uint32_t len = GENX(3DMESH_1D_length) + uses_drawid;
-   anv_batch_emitn(batch, len, GENX(3DMESH_1D),
+   uint32_t *dw = anv_batch_emitn(batch, len, GENX(3DMESH_1D),
                    .PredicateEnable           = predicate_enable,
                    .IndirectParameterEnable   = true,
                    .ExtendedParameter0Present = uses_drawid);
+   if (uses_drawid)
+      dw[len - 1] = 0;
 }
 
 void