Mesa (main): aco: Fix VOP2 instruction format in visit_tex.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Apr 13 13:24:22 UTC 2022
Module: Mesa
Branch: main
Commit: b874a2ed61b056fd69fc2aa4cbf2291d95177b23
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=b874a2ed61b056fd69fc2aa4cbf2291d95177b23
Author: Timur Kristóf <timur.kristof at gmail.com>
Date: Wed Apr 13 14:11:18 2022 +0200
aco: Fix VOP2 instruction format in visit_tex.
There was a v_or_b32 that accidentally used SOP2.
It should use VOP2.
Issue found by looking at a gfxreconstruct trace posted by a user
in this bug: https://gitlab.freedesktop.org/mesa/mesa/-/issues/5838
Cc: mesa-stable
Fixes: 93c8ebfa780ebd1495095e794731881aef29e7d3 "aco: Initial commit of independent AMD compiler"
Signed-off-by: Timur Kristóf <timur.kristof at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15923>
---
src/amd/compiler/aco_instruction_selection.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/amd/compiler/aco_instruction_selection.cpp b/src/amd/compiler/aco_instruction_selection.cpp
index 7caba87e134..887591c321c 100644
--- a/src/amd/compiler/aco_instruction_selection.cpp
+++ b/src/amd/compiler/aco_instruction_selection.cpp
@@ -9083,7 +9083,7 @@ visit_tex(isel_context* ctx, nir_tex_instr* instr)
}
if (pack_const && pack != Temp())
- pack = bld.sop2(aco_opcode::v_or_b32, bld.def(v1), Operand::c32(pack_const), pack);
+ pack = bld.vop2(aco_opcode::v_or_b32, bld.def(v1), Operand::c32(pack_const), pack);
}
if (pack_const && pack == Temp())
offset = bld.copy(bld.def(v1), Operand::c32(pack_const));
More information about the mesa-commit
mailing list