Mesa (main): radv: don't require robust vectorization for nir_var_mem_global

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Wed Apr 13 17:21:07 UTC 2022


Module: Mesa
Branch: main
Commit: 0360e12ebf7b3d29b038c6e188aa5761a4250fea
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=0360e12ebf7b3d29b038c6e188aa5761a4250fea

Author: Rhys Perry <pendingchaos02 at gmail.com>
Date:   Thu Apr 15 14:22:11 2021 +0100

radv: don't require robust vectorization for nir_var_mem_global

Robust vectorization is to prevent vectorization of loads using the near
maximum offset with loads of offset 0. Global loads can't read from offset
0 (NULL) anyways, so this isn't necessary.

No fossil-db changes.

Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14124>

---

 src/amd/vulkan/radv_pipeline.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_pipeline.c b/src/amd/vulkan/radv_pipeline.c
index 8bdc0bb06b8..069b69d915c 100644
--- a/src/amd/vulkan/radv_pipeline.c
+++ b/src/amd/vulkan/radv_pipeline.c
@@ -4355,7 +4355,7 @@ radv_create_shaders(struct radv_pipeline *pipeline, struct radv_pipeline_layout
 
          if (device->robust_buffer_access2) {
             vectorize_opts.robust_modes =
-               nir_var_mem_ubo | nir_var_mem_ssbo | nir_var_mem_global | nir_var_mem_push_const;
+               nir_var_mem_ubo | nir_var_mem_ssbo | nir_var_mem_push_const;
          }
 
          if (nir_opt_load_store_vectorize(stages[i].nir, &vectorize_opts)) {



More information about the mesa-commit mailing list