Mesa (main): aco: Remove some old comments in aco_opcodes.py.
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Mon Apr 18 16:18:26 UTC 2022
Module: Mesa
Branch: main
Commit: a8b29094c2bebed517bb2196536c93da3ab5aeb1
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=a8b29094c2bebed517bb2196536c93da3ab5aeb1
Author: Georg Lehmann <dadschoorse at gmail.com>
Date: Mon Apr 18 13:11:56 2022 +0200
aco: Remove some old comments in aco_opcodes.py.
s_cmovk_i32 isn't GFX8_GFX9 only and s_version doesn't need a comment to say
it's GFX10+ exclusive. The encoding list is enough to provide this information,
as for other GFX10+ instructions.
Signed-off-by: Georg Lehmann <dadschoorse at gmail.com>
Reviewed-by: Timur Kristóf <timur.kristof at gmail.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16006>
---
src/amd/compiler/aco_opcodes.py | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/src/amd/compiler/aco_opcodes.py b/src/amd/compiler/aco_opcodes.py
index 15ecb1aacd4..d93d0d3c092 100644
--- a/src/amd/compiler/aco_opcodes.py
+++ b/src/amd/compiler/aco_opcodes.py
@@ -385,8 +385,8 @@ for (gfx6, gfx7, gfx8, gfx9, gfx10, name, cls) in default_class(SOP2, InstrClass
SOPK = {
# GFX6, GFX7, GFX8, GFX9, GFX10, name
(0x00, 0x00, 0x00, 0x00, 0x00, "s_movk_i32"),
- ( -1, -1, -1, -1, 0x01, "s_version"), # GFX10+
- (0x02, 0x02, 0x01, 0x01, 0x02, "s_cmovk_i32"), # GFX8_GFX9
+ ( -1, -1, -1, -1, 0x01, "s_version"),
+ (0x02, 0x02, 0x01, 0x01, 0x02, "s_cmovk_i32"),
(0x03, 0x03, 0x02, 0x02, 0x03, "s_cmpk_eq_i32"),
(0x04, 0x04, 0x03, 0x03, 0x04, "s_cmpk_lg_i32"),
(0x05, 0x05, 0x04, 0x04, 0x05, "s_cmpk_gt_i32"),
More information about the mesa-commit
mailing list