Mesa (main): radv: do not support UNIFORM_TEXEL_BUFFER with SRGB

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Apr 19 06:53:47 UTC 2022


Module: Mesa
Branch: main
Commit: 90db8346036cc295e10c188e072ee94fb441b174
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=90db8346036cc295e10c188e072ee94fb441b174

Author: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Date:   Mon Apr 18 15:38:00 2022 +0200

radv: do not support UNIFORM_TEXEL_BUFFER with SRGB

Looks like it can't be supported. Also disabled by PRO/AMDVLK.

Fixes new CTS dEQP-VK.texture.texel_buffer.uniform.srgb.*.

Signed-off-by: Samuel Pitoiset <samuel.pitoiset at gmail.com>
Acked-by: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Reviewed-by: Bas Nieuwenhuizen <bas at basnieuwenhuizen.nl>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16010>

---

 src/amd/vulkan/radv_formats.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/amd/vulkan/radv_formats.c b/src/amd/vulkan/radv_formats.c
index f8220d5f73b..6971bb713bf 100644
--- a/src/amd/vulkan/radv_formats.c
+++ b/src/amd/vulkan/radv_formats.c
@@ -748,7 +748,7 @@ radv_physical_device_get_format_properties(struct radv_physical_device *physical
    if (radv_is_buffer_format_supported(format, &scaled)) {
       if (format != VK_FORMAT_R64_UINT && format != VK_FORMAT_R64_SINT) {
          buffer |= VK_FORMAT_FEATURE_2_VERTEX_BUFFER_BIT;
-         if (!scaled)
+         if (!scaled && !vk_format_is_srgb(format))
             buffer |= VK_FORMAT_FEATURE_2_UNIFORM_TEXEL_BUFFER_BIT;
       }
       buffer |= VK_FORMAT_FEATURE_2_STORAGE_TEXEL_BUFFER_BIT |



More information about the mesa-commit mailing list