Mesa (main): zink: fix stride=0 for dynamic state vertex stride checking

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Apr 22 14:52:11 UTC 2022


Module: Mesa
Branch: main
Commit: 06df3ed5c0e9d26b393f2ebdaa26d87e59928da4
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=06df3ed5c0e9d26b393f2ebdaa26d87e59928da4

Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date:   Thu Apr 21 10:09:34 2022 -0400

zink: fix stride=0 for dynamic state vertex stride checking

this case shouldn't trigger the fully-baked fallback since it's
legal with dynamic state

Fixes: 1eada1b02d3 ("zink: selectively disable dynamic vertex stride")

Reviewed-by: Erik Faye-Lund <erik.faye-lund at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16098>

---

 src/gallium/drivers/zink/zink_program.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/zink/zink_program.c b/src/gallium/drivers/zink/zink_program.c
index b0b41692caa..7dee9573389 100644
--- a/src/gallium/drivers/zink/zink_program.c
+++ b/src/gallium/drivers/zink/zink_program.c
@@ -787,7 +787,7 @@ check_vertex_strides(struct zink_context *ctx)
    for (unsigned i = 0; i < ves->hw_state.num_bindings; i++) {
       const struct pipe_vertex_buffer *vb = ctx->vertex_buffers + ves->binding_map[i];
       unsigned stride = vb->buffer.resource ? vb->stride : 0;
-      if (stride < ves->min_stride[i])
+      if (stride && stride < ves->min_stride[i])
          return false;
    }
    return true;



More information about the mesa-commit mailing list