Mesa (main): meson: call run_command with check=true

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Mon Apr 25 19:19:30 UTC 2022


Module: Mesa
Branch: main
Commit: dbceb561b054fbfc6dbaae14388dd7adec21453b
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=dbceb561b054fbfc6dbaae14388dd7adec21453b

Author: Michel Zou <xantares09 at hotmail.com>
Date:   Wed Apr  6 20:09:27 2022 +0200

meson: call run_command with check=true

This avoids a warning in meson since the default value will change:
WARNING: You should add the boolean check kwarg to the run_command call.
         It currently defaults to false,
         but it will default to true in future releases of meson.
         See also: https://github.com/mesonbuild/meson/issues/9300

It's probably best to use the new default (true) that the old (false)

Reviewed-by: Kai Wasserbäch <kai at dev.carbon-project.org>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15776>

---

 src/util/meson.build | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/util/meson.build b/src/util/meson.build
index 6a2e9dfd75d..1443a890eb2 100644
--- a/src/util/meson.build
+++ b/src/util/meson.build
@@ -387,7 +387,8 @@ if with_tests
     # https://gitlab.freedesktop.org/mesa/mesa/-/issues/2788
     prog_winepath = find_program('winepath')
     process_test_exe_full_path = run_command(
-      prog_winepath, '-w', process_test_exe.full_path()
+      prog_winepath, '-w', process_test_exe.full_path(),
+      check : true
     ).stdout().strip()
   else
     process_test_exe_full_path = process_test_exe.full_path()



More information about the mesa-commit mailing list