Mesa (main): vulkan: Use ALL_COMMANDS_BIT for waits/signals instead of ~0

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Tue Apr 26 14:45:35 UTC 2022


Module: Mesa
Branch: main
Commit: e0f27eca7abbb7ab39734207ca4d89b5fee96c37
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=e0f27eca7abbb7ab39734207ca4d89b5fee96c37

Author: Jason Ekstrand <jason.ekstrand at collabora.com>
Date:   Mon Apr 25 12:25:17 2022 -0500

vulkan: Use ALL_COMMANDS_BIT for waits/signals instead of ~0

This is a bit more accurate for what's going on and, while all Mesa
drivers today seem to be ok with extra bits, ensures we're passing a
valid Vulkan thing.

Reviewed-by: Iago Toral Quiroga <itoral at igalia.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/16145>

---

 src/vulkan/runtime/vk_queue.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/vulkan/runtime/vk_queue.c b/src/vulkan/runtime/vk_queue.c
index 9c1df73aed8..cdfbf718489 100644
--- a/src/vulkan/runtime/vk_queue.c
+++ b/src/vulkan/runtime/vk_queue.c
@@ -800,7 +800,7 @@ vk_queue_submit(struct vk_queue *queue,
       assert(submit->signals[signal_count].sync == NULL);
       submit->signals[signal_count++] = (struct vk_sync_signal) {
          .sync = mem_sync,
-         .stage_mask = ~(VkPipelineStageFlags2KHR)0,
+         .stage_mask = VK_PIPELINE_STAGE_2_ALL_COMMANDS_BIT,
       };
    }
 
@@ -808,7 +808,7 @@ vk_queue_submit(struct vk_queue *queue,
       assert(submit->signals[signal_count].sync == NULL);
       submit->signals[signal_count++] = (struct vk_sync_signal) {
          .sync = vk_fence_get_active_sync(info->fence),
-         .stage_mask = ~(VkPipelineStageFlags2KHR)0,
+         .stage_mask = VK_PIPELINE_STAGE_2_ALL_COMMANDS_BIT,
       };
    }
 
@@ -1071,7 +1071,7 @@ vk_queue_signal_sync(struct vk_queue *queue,
 
    submit->signals[0] = (struct vk_sync_signal) {
       .sync = sync,
-      .stage_mask = ~(VkPipelineStageFlags2KHR)0,
+      .stage_mask = VK_PIPELINE_STAGE_2_ALL_COMMANDS_BIT,
       .signal_value = signal_value,
    };
 



More information about the mesa-commit mailing list