Mesa (main): isl: disable mcs (and mcs+ccs) for color msaa on DG2

[GitLab Mirror]

Module: Mesa
Branch: main
Commit: d3ef3657b280b3c273957641183e64d388804d08
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=d3ef3657b280b3c273957641183e64d388804d08

Author: Tapani Pälli <tapani.palli at intel.com>
Date:   Sat Apr 23 09:29:08 2022 +0300

isl: disable mcs (and mcs+ccs) for color msaa on DG2

Fixes lots of various test failures in:
   dEQP-VK.pipeline.multisample.min_sample_shading_disabled.*
   dEQP-GLES3.functional*multisample.*
   KHR-GL*sample_variables.*

Cc: mesa-stable
Signed-off-by: Tapani Pälli <tapani.palli at intel.com>
Acked-by: Kenneth Graunke <kenneth at whitecape.org>
Acked-by: Nanley Chery <nanley.g.chery at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13991>

---

 src/intel/isl/isl.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/src/intel/isl/isl.c b/src/intel/isl/isl.c
index 56e10f256c7..ca8d26b78c7 100644
--- a/src/intel/isl/isl.c
+++ b/src/intel/isl/isl.c
@@ -2097,6 +2097,10 @@ isl_surf_get_mcs_surf(const struct isl_device *dev,
    if (surf->msaa_layout != ISL_MSAA_LAYOUT_ARRAY)
       return false;
 
+   /* We are seeing failures with mcs on dg2, so disable it for now. */
+   if (intel_device_info_is_dg2(dev->info))
+      return false;
+
    /* The following are true of all multisampled surfaces */
    assert(surf->samples > 1);
    assert(surf->dim == ISL_SURF_DIM_2D);