Mesa (main): ci/lava: Always validate the lava job

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Apr 28 07:34:16 UTC 2022


Module: Mesa
Branch: main
Commit: 33a1c51e3e700b4483507e486e876ae7a09456df
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=33a1c51e3e700b4483507e486e876ae7a09456df

Author: Guilherme Gallo <guilherme.gallo at collabora.com>
Date:   Tue Mar 22 22:02:59 2022 -0300

ci/lava: Always validate the lava job

Signed-off-by: Guilherme Gallo <guilherme.gallo at collabora.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/15938>

---

 .gitlab-ci/lava/lava_job_submitter.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/.gitlab-ci/lava/lava_job_submitter.py b/.gitlab-ci/lava/lava_job_submitter.py
index d8cbf2a8ad3..b73ea692626 100755
--- a/.gitlab-ci/lava/lava_job_submitter.py
+++ b/.gitlab-ci/lava/lava_job_submitter.py
@@ -384,13 +384,13 @@ def main(args):
     if args.dump_yaml:
         print("LAVA job definition (YAML):")
         print(hide_sensitive_data(job_definition))
+    job = LAVAJob(proxy, job_definition)
+
+    if errors := job.validate():
+        fatal_err(f"Error in LAVA job definition: {errors}")
+    print_log("LAVA job definition validated successfully")
 
     if args.validate_only:
-        job = LAVAJob(proxy, job_definition)
-        ret = job.validate()
-        if ret:
-            fatal_err("Error in LAVA job definition")
-        print("LAVA job definition validated successfully")
         return
 
     ret = retriable_follow_job(proxy, job_definition)



More information about the mesa-commit mailing list