Mesa (main): anv: Add support for non-zero firstTask in vkCmdDrawMeshTasksNV
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Wed Feb 2 18:36:13 UTC 2022
Module: Mesa
Branch: main
Commit: f12f5ae2f8d4b394e31b3b39c3385f74a4abff86
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f12f5ae2f8d4b394e31b3b39c3385f74a4abff86
Author: Marcin Ślusarz <marcin.slusarz at intel.com>
Date: Mon Jul 5 15:48:03 2021 +0200
anv: Add support for non-zero firstTask in vkCmdDrawMeshTasksNV
Signed-off-by: Marcin Ślusarz <marcin.slusarz at intel.com>
Reviewed-by: Lionel Landwerlin <lionel.g.landwerlin at intel.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/13662>
---
src/intel/vulkan/genX_cmd_buffer.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/src/intel/vulkan/genX_cmd_buffer.c b/src/intel/vulkan/genX_cmd_buffer.c
index f5e39fced96..5b7e05ea60f 100644
--- a/src/intel/vulkan/genX_cmd_buffer.c
+++ b/src/intel/vulkan/genX_cmd_buffer.c
@@ -4857,12 +4857,15 @@ genX(CmdDrawMeshTasksNV)(
if (cmd_buffer->state.conditional_render_enabled)
genX(cmd_emit_conditional_render_predicate)(cmd_buffer);
- /* TODO(mesh): Support non-zero firstTask. */
- assert(firstTask == 0);
+ /* BSpec 54016 says: "The values passed for Starting ThreadGroup ID X
+ * and ThreadGroup Count X shall not cause TGIDs to exceed (2^32)-1."
+ */
+ assert((int64_t)firstTask + taskCount - 1 <= UINT32_MAX);
anv_batch_emit(&cmd_buffer->batch, GENX(3DMESH_1D), m) {
m.PredicateEnable = cmd_buffer->state.conditional_render_enabled;
m.ThreadGroupCountX = taskCount;
+ m.StartingThreadGroupIDX = firstTask;
}
}
More information about the mesa-commit
mailing list