Mesa (main): aco: fix neg(mul)/abs(mul) optimization with different bit-size

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Thu Feb 3 16:21:09 UTC 2022


Module: Mesa
Branch: main
Commit: 6b1dfa7eac2bd1e0dfb15febd0435b899101edb7
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=6b1dfa7eac2bd1e0dfb15febd0435b899101edb7

Author: Rhys Perry <pendingchaos02 at gmail.com>
Date:   Mon Jan 31 18:28:59 2022 +0000

aco: fix neg(mul)/abs(mul) optimization with different bit-size

Signed-off-by: Rhys Perry <pendingchaos02 at gmail.com>
Reviewed-by: Daniel Schürmann <daniel at schuermann.dev>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14810>

---

 src/amd/compiler/aco_optimizer.cpp | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/src/amd/compiler/aco_optimizer.cpp b/src/amd/compiler/aco_optimizer.cpp
index 7dfdb05e3ff..448c3a744f5 100644
--- a/src/amd/compiler/aco_optimizer.cpp
+++ b/src/amd/compiler/aco_optimizer.cpp
@@ -3509,6 +3509,8 @@ combine_instruction(opt_ctx& ctx, aco_ptr<Instruction>& instr)
       if (mul_instr->opcode == aco_opcode::v_mul_legacy_f32 &&
           ctx.fp_mode.preserve_signed_zero_inf_nan32)
          return;
+      if (mul_instr->definitions[0].bytes() != instr->definitions[0].bytes())
+         return;
 
       /* convert to mul(neg(a), b), mul(abs(a), abs(b)) or mul(neg(abs(a)), abs(b)) */
       ctx.uses[mul_instr->definitions[0].tempId()]--;



More information about the mesa-commit mailing list