Mesa (main): llvmpipe: just move opaque alpha lookup closer to use.

GitLab Mirror gitlab-mirror at kemper.freedesktop.org
Fri Feb 4 06:47:13 UTC 2022


Module: Mesa
Branch: main
Commit: cd4d2e920cbf05b000b8288a8f78987f23c182c3
URL:    http://cgit.freedesktop.org/mesa/mesa/commit/?id=cd4d2e920cbf05b000b8288a8f78987f23c182c3

Author: Dave Airlie <airlied at redhat.com>
Date:   Thu Feb  3 12:58:45 2022 +1000

llvmpipe: just move opaque alpha lookup closer to use.

Saves looking this up before checking the variant.

Reviewed-by: Jose Fonseca <jfonseca at vmware.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14846>

---

 src/gallium/drivers/llvmpipe/lp_setup_tri.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/gallium/drivers/llvmpipe/lp_setup_tri.c b/src/gallium/drivers/llvmpipe/lp_setup_tri.c
index e988ddfe641..76c803ae785 100644
--- a/src/gallium/drivers/llvmpipe/lp_setup_tri.c
+++ b/src/gallium/drivers/llvmpipe/lp_setup_tri.c
@@ -233,7 +233,6 @@ check_opaque(struct lp_setup_context *setup,
 {
    const struct lp_fragment_shader_variant *variant =
       setup->fs.current.variant;
-   const struct lp_tgsi_channel_info *alpha_info = &variant->shader->info.cbuf[0][3];
 
    if (variant->opaque)
       return TRUE;
@@ -241,6 +240,7 @@ check_opaque(struct lp_setup_context *setup,
    if (!variant->potentially_opaque)
       return FALSE;
 
+   const struct lp_tgsi_channel_info *alpha_info = &variant->shader->info.cbuf[0][3];
    if (alpha_info->file == TGSI_FILE_CONSTANT) {
       const float *constants = setup->fs.current.jit_context.constants[0];
       float alpha = constants[alpha_info->u.index*4 +



More information about the mesa-commit mailing list