Mesa (staging/21.3): llvmpipe: disable PIPE_SHADER_CAP_FP16_CONST_BUFFERS
GitLab Mirror
gitlab-mirror at kemper.freedesktop.org
Fri Feb 4 21:28:09 UTC 2022
Module: Mesa
Branch: staging/21.3
Commit: f052bd174c8da82d034a9ffc395fe43c0d8e7843
URL: http://cgit.freedesktop.org/mesa/mesa/commit/?id=f052bd174c8da82d034a9ffc395fe43c0d8e7843
Author: Mike Blumenkrantz <michael.blumenkrantz at gmail.com>
Date: Wed Feb 2 15:54:45 2022 -0500
llvmpipe: disable PIPE_SHADER_CAP_FP16_CONST_BUFFERS
this cap is broken
cc: mesa-stable
fixes:
GTF-GL46.gtf21.GL2Tests.glGetUniform.glGetUnifor
Reviewed-by: Dave Airlie <airlied at redhat.com>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/14835>
(cherry picked from commit 9a75392cd829df3f8f5a89dfecd4f2103658bfbd)
---
.pick_status.json | 2 +-
src/gallium/auxiliary/gallivm/lp_bld_limits.h | 4 +++-
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/.pick_status.json b/.pick_status.json
index 5cacadfdcf2..e8369f70ae6 100644
--- a/.pick_status.json
+++ b/.pick_status.json
@@ -814,7 +814,7 @@
"description": "llvmpipe: disable PIPE_SHADER_CAP_FP16_CONST_BUFFERS",
"nominated": true,
"nomination_type": 0,
- "resolution": 0,
+ "resolution": 1,
"main_sha": null,
"because_sha": null
},
diff --git a/src/gallium/auxiliary/gallivm/lp_bld_limits.h b/src/gallium/auxiliary/gallivm/lp_bld_limits.h
index 573237e23d0..55778f2b6fb 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_limits.h
+++ b/src/gallium/auxiliary/gallivm/lp_bld_limits.h
@@ -132,8 +132,10 @@ gallivm_get_shader_param(enum pipe_shader_cap param)
return 1;
case PIPE_SHADER_CAP_FP16:
case PIPE_SHADER_CAP_FP16_DERIVATIVES:
- case PIPE_SHADER_CAP_FP16_CONST_BUFFERS:
return lp_has_fp16();
+ //enabling this breaks GTF-GL46.gtf21.GL2Tests.glGetUniform.glGetUniform
+ case PIPE_SHADER_CAP_FP16_CONST_BUFFERS:
+ return 0;
case PIPE_SHADER_CAP_INT64_ATOMICS:
return 0;
case PIPE_SHADER_CAP_INT16:
More information about the mesa-commit
mailing list